feat: sic metadata gen and ingestion #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balajismaniam
requested review from
a team,
asrivas,
telpirion,
yil532 and
nicain
as code owners
balajismaniam
force-pushed
the
sic-metadata-gen
branch
from
edf46c5 to
4d3cfcb
Compare
telpirion
approved these changes
Jul 12, 2023
nicain
reviewed
Jul 12, 2023
| @@ -26,6 +26,7 @@ variable "project_id" { | |||
| variable "bucket_name" { | |||
| description = "The name of the bucket to create" | |||
| type = string | |||
| default = "genai-doc-summary-webhook-1234" | |||
There was a problem hiding this comment.
Is this really the bucket name?
There was a problem hiding this comment.
Just the default one. It reduces one more input requirement in SiC. Do you have suggestion for a better default? While testing we use some random suffix: https://github.com/GoogleCloudPlatform/terraform-genai-doc-summarization/blob/main/examples/simple_example/main.tf#L25.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.