Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: simplify webhook code #114

Merged
merged 52 commits into from
May 13, 2024
Merged

chore!: simplify webhook code #114

merged 52 commits into from
May 13, 2024

Conversation

davidcavazos
Copy link
Collaborator

@davidcavazos davidcavazos commented Apr 12, 2024

Main changes

⚠️ Note: This PR includes breaking changes, but will make the code and maintenance simpler at the long run.

Terraform

  • Simplify terraform to make it easier to maintain
  • Simplify required permissions and roles
  • Include unique prefix on resources to avoid name clashes with other solutions
  • Update terraform package versions
  • Update Makefile to generate metadata
  • Move BigQuery schema to its own file

Webhook code

  • Simplify webhook code
  • Simplify webhook tests
  • Use Document AI instead of Vision API
  • Use Gemini instead of PaLM
  • Improve webhook github actions linter and tests
  • Add Python lint check with ruff
  • Add Python type checking with mypy
  • Upgrade Python dependencies
  • Remove notebook since it's already covered by the Neos tutorial

TO DO before merging

@davidcavazos davidcavazos added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 15, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@davidcavazos davidcavazos merged commit 083d7da into main May 13, 2024
9 checks passed
@davidcavazos davidcavazos deleted the webhook branch May 13, 2024 17:28
@davidcavazos davidcavazos removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kokoro:force-run Add this label to force Kokoro to re-run the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants