Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collector: upgrade collector core components to v0.102 #36

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

ridwanmsharif
Copy link
Collaborator

Change-Id: Id11d485e02a1393181e64d6eb9e9e508098475ce

Change-Id: Id11d485e02a1393181e64d6eb9e9e508098475ce
@ridwanmsharif ridwanmsharif requested a review from braydonk June 12, 2024 02:59
Copy link

@braydonk braydonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small comments but LGTM otherwise

Dockerfile Outdated
@@ -1,4 +1,4 @@
FROM golang:1.20.12 as builder
FROM golang:1.21.0 as builder

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason not to go to 1.21.11?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Makefile Outdated
@@ -63,7 +63,9 @@ install-tools:
github.com/client9/misspell/cmd/misspell \
github.com/golangci/golangci-lint/cmd/golangci-lint \
github.com/google/addlicense \
github.com/open-telemetry/opentelemetry-collector-contrib/cmd/mdatagen
go.opentelemetry.io/collector/cmd/mdatagen \
github.com/google/googet/goopack \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you do a googet package of this repo? If not you probably don't need this

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Change-Id: I9a9d48a9125e90d6c5d145a9e922ab0a75d4a4b0
@ridwanmsharif ridwanmsharif merged commit b42d124 into main Jun 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants