entrypoint: add liveness probe endpoint to the sidecar #33
Conversation
| @@ -34,6 +35,9 @@ var userConfigFile = "/etc/rungmp/config.yaml" | |||
| var otelConfigFile = "/run/rungmp/otel.yaml" | |||
| var configRefreshInterval = 20 * time.Second | |||
| var selfMetricsPort = 0 | |||
| var livenessProbePort = 13133 | |||
There was a problem hiding this comment.
I used this because this is the port we set up for the OTel sidecar https://cloud.google.com/run/docs/tutorials/custom-metrics-opentelemetry-sidecar#ship-code
Its the default port for the healthcehck extension in OTel. But maybe we don't want to reuse this port because of that? I don't have strong opinions - wdyt @jefferbrecht?
There was a problem hiding this comment.
As long as there's never a reason to run both at the same time then it should be fine.
This change uses the liveness probes as a way to guarantee a regular period of uninterrupted CPU for the sidecar to complete its prometheus scrapes and flushes to GMP. Change-Id: Ic6f0ed38ade237d6179dea12268cd2575d221146
ridwanmsharif
force-pushed
the
ridwanmsharif/sidecar-healthcheck
branch
from
b48c63a to
cc1ede6
Compare
Change-Id: Id31f5294721e6583af84aa4127b8bae21a243267
| @@ -11,7 +11,6 @@ RUN make build | |||
|
|
|||
| FROM alpine:latest | |||
| RUN apk add --no-cache ca-certificates | |||
| RUN apk add openssl=3.1.4-r6 && apk upgrade openssl --no-cache | |||
There was a problem hiding this comment.
Just noticed this; why no need for openssl anymore? Or was it there by accident in the first place?
There was a problem hiding this comment.
We do need it, we pinned it to a version because the one alpine packaged had a vuln in it. Latest has now updated and this is no longer necessary so cleaned it up.
b/326279447
This change uses the liveness probes as a way to guarantee a regular period of uninterrupted CPU for the sidecar to complete its prometheus scrapes and flushes to GMP.
Change-Id: Ic6f0ed38ade237d6179dea12268cd2575d221146