Add check for required statuses. #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theacodes
reviewed
Mar 20, 2018
webhook-app/webhooks.py
Outdated
| @@ -183,6 +183,11 @@ def merge_pull_request(repo, pull, commit_sha=None): | |||
| logging.info('Not merging {}, not labeled automerge'.format(pull)) | |||
| return | |||
|
|
|||
| # only merge if all required status are reported | |||
| if not github_helper.has_required_statuses(pull): | |||
| logging.info('Not merging {}, missing required status') | |||
|
deployed. |
|
@lesv FYI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a check that all statuses are required by the protections on the branch are required to be reported before DPE bot merges a branch. This will help prevent accidental merges like GoogleCloudPlatform/java-docs-samples#1049 when a required check hasn't started yet.
Protection API Reference
I've tested the new functions locally to confirm that they work, but there is a difference between some of the syntax in the older functions. I was unable to get the following to work:
and instead had to use:
I am not sure why this is, but suspected maybe a difference in library version. If you can clarify which is preferred for DPEbots environment, I can update to whatever works.