Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(speech): Add Speech-to-Text On-Prem sample #4223

Merged
merged 6 commits into from
Jul 22, 2020
Merged

feat(speech): Add Speech-to-Text On-Prem sample #4223

merged 6 commits into from
Jul 22, 2020

Conversation

vinnysenthil
Copy link
Contributor

@vinnysenthil vinnysenthil commented Jul 1, 2020 •
edited
Loading

Description

Fixes #4222

Adding sample to demonstrate speech transcription for on-prem customers. This sample does not currently contain tests due to being on-prem.

Note: It's a good idea to open an issue first for discussion.

Checklist

@vinnysenthil vinnysenthil added cla: yes This human has signed the Contributor License Agreement. automerge Merge the pull request once unit tests and other checks pass. labels Jul 1, 2020
@vinnysenthil vinnysenthil marked this pull request as ready for review July 1, 2020 17:23
@vinnysenthil vinnysenthil requested review from sirtorry and a team as code owners July 1, 2020 17:23
busunkim96
busunkim96 reviewed Jul 1, 2020
View reviewed changes
speech/cloud-client/transcribe_onprem.py Outdated Show resolved Hide resolved
speech/cloud-client/transcribe_onprem.py Outdated Show resolved Hide resolved
@leahecole leahecole removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 1, 2020
@leahecole
Copy link
Collaborator

leahecole commented Jul 1, 2020 •
edited
Loading

I understand that this sample will look a little different test-wise than others because of the nature of it being on-prem - I'm hesitant to have absolutely no testing though. My two questions related to that are:

  1. How would we recommend a customer test this if they were running on prem? Without thinking too hard about it, my guess is it would be a system test with something on prem or something with mocks (or maybe something else - I really didn't go too deep in my thought process here) - and if that's the case, would it be valuable to include that here?
  2. With an on-prem sample like this, how can you as the codeowner and we as repo owners know that this code is out of date? Normally we rely on tests for breaking changes, and I'm worried that with nothing we won't be able to figure out quickly when something is broken.

@gcf-merge-on-green
Copy link
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@leahecole leahecole added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 6, 2020
@leahecole
Copy link
Collaborator

Just adding the "do not merge" label while we figure out an appropriate test strategy

@leahecole leahecole mentioned this pull request Jul 22, 2020
Closed
@leahecole leahecole removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 22, 2020
@vinnysenthil vinnysenthil requested a review from busunkim96 July 22, 2020 22:48
@leahecole leahecole merged commit e67b014 into master Jul 22, 2020
@leahecole leahecole deleted the speech-transcribe-onprem branch July 22, 2020 22:52
busunkim96 pushed a commit to busunkim96/python-speech that referenced this pull request Sep 1, 2020
@vinnysenthil @leahecole
feat(speech): Add Speech-to-Text On-Prem sample [(#4223)](GoogleCloud…
5d7b41f 
…Platform/python-docs-samples#4223)

* feat: adds speech-to-text onprem sample

* Remove client options and change to f-strings

* Move to onprem folder, add resource and README

Co-authored-by: Leah E. Cole <[email protected]>
busunkim96 pushed a commit to googleapis/python-speech that referenced this pull request Sep 3, 2020
@vinnysenthil @leahecole @busunkim96
feat(speech): Add Speech-to-Text On-Prem sample [(#4223)](GoogleCloud…
fbe1e77 
…Platform/python-docs-samples#4223)

* feat: adds speech-to-text onprem sample

* Remove client options and change to f-strings

* Move to onprem folder, add resource and README

Co-authored-by: Leah E. Cole <[email protected]>
@release-please release-please bot mentioned this pull request Sep 3, 2020
Closed
@release-please release-please bot mentioned this pull request Sep 24, 2020
Merged
@dandhlee dandhlee mentioned this pull request Feb 25, 2022
Closed
@telpirion telpirion mentioned this pull request Jan 13, 2023
Merged
8 tasks
telpirion pushed a commit that referenced this pull request Jan 13, 2023
@vinnysenthil @leahecole @busunkim96
feat(speech): Add Speech-to-Text On-Prem sample [(#4223)](#4223)
12404d3 
* feat: adds speech-to-text onprem sample

* Remove client options and change to f-strings

* Move to onprem folder, add resource and README

Co-authored-by: Leah E. Cole <[email protected]>
dandhlee pushed a commit that referenced this pull request Feb 9, 2023
@vinnysenthil @leahecole @dandhlee
feat(speech): Add Speech-to-Text On-Prem sample [(#4223)](#4223)
6363555 
* feat: adds speech-to-text onprem sample

* Remove client options and change to f-strings

* Move to onprem folder, add resource and README

Co-authored-by: Leah E. Cole <[email protected]>
telpirion pushed a commit that referenced this pull request Mar 13, 2023
@vinnysenthil @leahecole @telpirion
feat(speech): Add Speech-to-Text On-Prem sample [(#4223)](#4223)
03cd9af 
* feat: adds speech-to-text onprem sample

* Remove client options and change to f-strings

* Move to onprem folder, add resource and README

Co-authored-by: Leah E. Cole <[email protected]>
atulep pushed a commit to googleapis/google-cloud-python that referenced this pull request Apr 6, 2023
@vinnysenthil @leahecole @busunkim96
feat(speech): Add Speech-to-Text On-Prem sample [(#4223)](GoogleCloud…
30c8c64 
…Platform/python-docs-samples#4223)

* feat: adds speech-to-text onprem sample

* Remove client options and change to f-strings

* Move to onprem folder, add resource and README

Co-authored-by: Leah E. Cole <[email protected]>
atulep pushed a commit to googleapis/google-cloud-python that referenced this pull request Apr 6, 2023
@vinnysenthil @leahecole @busunkim96
feat(speech): Add Speech-to-Text On-Prem sample [(#4223)](GoogleCloud…
d042c0b 
…Platform/python-docs-samples#4223)

* feat: adds speech-to-text onprem sample

* Remove client options and change to f-strings

* Move to onprem folder, add resource and README

Co-authored-by: Leah E. Cole <[email protected]>
atulep pushed a commit to googleapis/google-cloud-python that referenced this pull request Apr 18, 2023
@vinnysenthil @leahecole @busunkim96
feat(speech): Add Speech-to-Text On-Prem sample [(#4223)](GoogleCloud…
2cfe736 
…Platform/python-docs-samples#4223)

* feat: adds speech-to-text onprem sample

* Remove client options and change to f-strings

* Move to onprem folder, add resource and README

Co-authored-by: Leah E. Cole <[email protected]>
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Oct 22, 2023
@vinnysenthil @leahecole @busunkim96
feat(speech): Add Speech-to-Text On-Prem sample [(#4223)](GoogleCloud…
9e201f5 
…Platform/python-docs-samples#4223)

* feat: adds speech-to-text onprem sample

* Remove client options and change to f-strings

* Move to onprem folder, add resource and README

Co-authored-by: Leah E. Cole <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

@leahecole leahecole leahecole approved these changes

@telpirion telpirion Awaiting requested review from telpirion

@sirtorry sirtorry Awaiting requested review from sirtorry

Assignees

@leahecole leahecole

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Speech-to-Text On-Prem sample
3 participants
@vinnysenthil @leahecole @busunkim96