Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tests for the twilio sample. Fixes #183 #354

Merged
merged 1 commit into from
May 18, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion managed_vms/twilio/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def send_sms():
to = request.args.get('to')
if not to:
return ('Please provide the number to message in the "to" query string'
' parameter.')
' parameter.'), 400

client = TwilioRestClient(TWILIO_ACCOUNT_SID, TWILIO_AUTH_TOKEN)
rv = client.messages.create(
Expand Down
67 changes: 67 additions & 0 deletions managed_vms/twilio/main_test.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
# Copyright 2016 Google Inc. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

import json

from googleapiclient.http import HttpMockSequence
import httplib2
import pytest


class HttpMockSequenceWithCredentials(HttpMockSequence):
def add_credentials(self, *args):
pass


@pytest.fixture
def app(monkeypatch):
monkeypatch.setenv('TWILIO_ACCOUNT_SID', 'sid123')
monkeypatch.setenv('TWILIO_AUTH_TOKEN', 'auth123')
monkeypatch.setenv('TWILIO_NUMBER', '0123456789')

import main

main.app.testing = True
return main.app.test_client()


def test_receive_call(app):
r = app.post('/call/receive')
assert 'Hello from Twilio!' in r.data.decode('utf-8')


def test_send_sms(app, monkeypatch):
httpmock = HttpMockSequenceWithCredentials([
({'status': '200'}, json.dumps({
'sid': 'sid123'
}))
])

def mock_http_ctor(*args, **kwargs):
return httpmock

monkeypatch.setattr(httplib2, 'Http', mock_http_ctor)

r = app.get('/sms/send')
assert r.status_code == 400

r = app.get('/sms/send?to=5558675309')
assert r.status_code == 200


def test_receive_sms(app):
r = app.post('/sms/receive', data={
'From': '5558675309', 'Body': 'Jenny, I got your number.'})
assert r.status_code == 200
assert 'Jenny, I got your number' in r.data.decode('utf-8')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to make you mine 🎵 🎵 🎵