Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spanner: Add Cloud Spanner Backup samples #3101

Merged
merged 19 commits into from
Mar 30, 2020
Merged

spanner: Add Cloud Spanner Backup samples #3101

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
a5f4fd9
add backup samples
larkee Mar 16, 2020
e32a5f9
update required spanner version
larkee Mar 17, 2020
762b8c6
fix lint errors
larkee Mar 17, 2020
c0f5ac4
run backup samples tests against a new instance
larkee Mar 18, 2020
71c3af0
fix lint
larkee Mar 18, 2020
f3a3d74
wait for instance creation to complete
larkee Mar 18, 2020
46667c2
Merge branch 'master' into python-spanner-backup-samples
larkee Mar 18, 2020
ee448ab
Apply suggestions from code review
larkee Mar 18, 2020
a4a6ba9
add list_backups test
larkee Mar 19, 2020
01bcbdb
fix lint
larkee Mar 19, 2020
9eab00f
add missing newline character in assert
larkee Mar 19, 2020
5ab3bc1
Merge branch 'master' into python-spanner-backup-samples
larkee Mar 19, 2020
3ea6cb1
Merge branch 'master' into python-spanner-backup-samples
larkee Mar 24, 2020
9d429b9
update samples to be consistent with other languages
larkee Mar 27, 2020
447ad6b
lint fix
larkee Mar 27, 2020
39ee4d9
add pagination sample
larkee Mar 27, 2020
bd69f6f
Merge branch 'master' into python-spanner-backup-samples
larkee Mar 27, 2020
a1be3a4
reorder tests
larkee Mar 29, 2020
5e08053
Merge branch 'master' into python-spanner-backup-samples
larkee Mar 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
wait for instance creation to complete
  • Loading branch information
@larkee
larkee committed Mar 18, 2020
commit f3a3d747cac37d0164e6d186f7fc9866829c06b0
3 changes: 2 additions & 1 deletion spanner/cloud-client/backup_sample_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@ def spanner_instance():
instance_config = '{}/instanceConfigs/{}'.format(
spanner_client.project_name, 'regional-us-central1')
instance = spanner_client.instance(INSTANCE_ID, instance_config)
instance.create()
op = instance.create()
op.result(30) # block until completion
yield instance
instance.delete()

Expand Down