Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix monitoring tests #2793

Closed
wants to merge 17 commits into from
Closed

Fix monitoring tests #2793

wants to merge 17 commits into from

Conversation

leahecole
Copy link
Collaborator

fixes #2792

@leahecole leahecole requested a review from a team as a code owner February 7, 2020 20:43
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 7, 2020
@leahecole leahecole added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 7, 2020
@leahecole
Copy link
Collaborator Author

Still working on figuring out cleanup - realizing my initial strategy is not valid for parallelization - I need to take a break and look again later

@leahecole
Copy link
Collaborator Author

Ugh the alerts tests are failing because of our parallel test runs, and the cloud-client failure is flaky and is marked as flaky, but still being considered a failure. I'm a little stuck here and taking another break (maybe a really long one) and if other folks have input please let me know!

@leahecole leahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 8, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 8, 2020
@leahecole leahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 8, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 8, 2020
@leahecole leahecole force-pushed the fix_monitoring_tests branch from 89ae899 to 67702a7 Compare February 8, 2020 05:33
@leahecole
Copy link
Collaborator Author

(just reverted to a state where more tests were passing than failing) - These tests do pass locally but just don't work when run in parallel - I'm out of clever ideas for now

@leahecole leahecole removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 8, 2020
@leahecole leahecole linked an issue Mar 4, 2020 that may be closed by this pull request
@tmatsuo
Copy link
Contributor

tmatsuo commented Apr 7, 2020

@leahecole FYI the alert-client tests will be somewhat fixed with #3285

although the solution there won't be the fundamental fix.

If your problem is seeing errors like "409 Too many concurrent edits", the only fundamental solution is to use multiple projects. One option is to create a new temporary project during setup and delete it on teardown, but I feel it's too wasteful. Other option is to pre-create multiple projects and pick one of the projects randomly.

Or, even we can completely avoid the problem by creating project with names following the build name.
For example, python3.5 will use the project python-docs-samples-test-python3.5 etc etc

@leahecole
Copy link
Collaborator Author

Closing this because I think @tmatsuo is looking into this, and I'd lost track of it completely

@leahecole leahecole closed this Apr 9, 2020
@leahecole leahecole deleted the fix_monitoring_tests branch November 10, 2020 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
5 participants