-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix monitoring tests #2793
Fix monitoring tests #2793
Conversation
Still working on figuring out cleanup - realizing my initial strategy is not valid for parallelization - I need to take a break and look again later |
…/python-docs-samples into fix_monitoring_tests
…/python-docs-samples into fix_monitoring_tests
Ugh the alerts tests are failing because of our parallel test runs, and the cloud-client failure is flaky and is marked as flaky, but still being considered a failure. I'm a little stuck here and taking another break (maybe a really long one) and if other folks have input please let me know! |
…/python-docs-samples into fix_monitoring_tests
89ae899
to
67702a7
Compare
(just reverted to a state where more tests were passing than failing) - These tests do pass locally but just don't work when run in parallel - I'm out of clever ideas for now |
@leahecole FYI the alert-client tests will be somewhat fixed with #3285 although the solution there won't be the fundamental fix. If your problem is seeing errors like "409 Too many concurrent edits", the only fundamental solution is to use multiple projects. One option is to create a new temporary project during setup and delete it on teardown, but I feel it's too wasteful. Other option is to pre-create multiple projects and pick one of the projects randomly. Or, even we can completely avoid the problem by creating project with names following the build name. |
Closing this because I think @tmatsuo is looking into this, and I'd lost track of it completely |
fixes #2792