Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vision region tag update #1635

Merged
merged 23 commits into from
Aug 16, 2018
Merged

Vision region tag update #1635

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
4eb12bd
updates region tags for face detection tutorial
alixhami Aug 10, 2018
f385d28
updates region tags for crop hints tutorial
alixhami Aug 10, 2018
86c1ca6
updates region tags for detecting-crop-hints page
alixhami Aug 10, 2018
ab42e85
updates region tags for detecting-faces page
alixhami Aug 10, 2018
52d4541
updates region tags for detecting-fulltext page
alixhami Aug 10, 2018
bcb2505
updates region tags for detecting-labels page
alixhami Aug 10, 2018
57937db
updates region tags for detecting-landmarks page
alixhami Aug 10, 2018
e4948ec
update region tags for detect-logos page
alixhami Aug 10, 2018
6f66348
update region tags for detecting-properties page
alixhami Aug 10, 2018
1c32f28
update region tags for detecting-safe-search page
alixhami Aug 10, 2018
b0b4cb0
update region tags for detecting-text page
alixhami Aug 10, 2018
969ea41
update region tags for detecting-web page
alixhami Aug 10, 2018
d2546a9
updates region tags for document text detection tutorial
alixhami Aug 10, 2018
462e422
updates region tags for web detection tutorial
alixhami Aug 10, 2018
02f8931
update beta snippet tags to standard
alixhami Aug 13, 2018
dcbbe35
update PDF detection region tags to standard
alixhami Aug 13, 2018
a21c39d
updates python migration region tags to standard
alixhami Aug 13, 2018
215a1a3
Updates product search region tags to standard
alixhami Aug 14, 2018
d51ec85
fixes region tags for face detection tutorial
alixhami Aug 14, 2018
846f067
adds import tag to face detection tutorial
alixhami Aug 14, 2018
525e3bc
fix region tags
alixhami Aug 14, 2018
4f6052c
fixes lint
alixhami Aug 15, 2018
07be308
fixes import lint
alixhami Aug 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
adds import tag to face detection tutorial
  • Loading branch information
@alixhami
alixhami committed Aug 14, 2018
commit 846f067620a178f00f2151d3068c96b341c57712
5 changes: 2 additions & 3 deletions vision/cloud-client/face_detection/faces.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,11 @@

import argparse

# [START vision_face_detection_tutorial_client]
# [START vision_face_detection_tutorial_imports]
from google.cloud import vision
from google.cloud.vision import types
from PIL import Image, ImageDraw

# [END vision_face_detection_tutorial_client]
# [END vision_face_detection_tutorial_imports]

# [START vision_face_detection_tutorial_send_request]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

send_request is a bit vague/generic.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's within the context of being the face detection tutorial, so I think it's an ok suffix. This was done to standardize across languages. def_detect_face is too vague because there is also a face detection sample for the how to guides.

def detect_face(face_file, max_results=4):
Expand Down