Vision API features update

[beccasaurus]

This is a REDO of the previous PR: Vision API features update #1339

(That PR deleted some Beta samples which are still required by the docs)

Reverted & brought back the Beta samples!

Let's try this again 😄

[beccasaurus]

I noticed that detect.py does not use the canonical region tags for its snippets (there are lots of unconventional def_.... region tags)

Is this a good time to change those? I was trying to copy detect.py, treating it as if it's the canonical, but it's really NOT CANONICAL for Vision snippets

/cc @sirtorry

[theacodes]

@remi totally up to you. Python uses indented_block because it keeps things simple and generally we can name the functions the same as the region tags (go also has similar go_func functionality). But it doesn't matter either way style-wise, it's just preference.

[beccasaurus]

For ML API samples (only) is it okay if we discontinue indented_ block and use explicit (globally unique, eg. vision_x) region tags (they will ideally always be the same as the function name). I'm starting to use a tool to organize ML API code samples and the tool loves region tags :)

On Thu, Feb 8, 2018 at 3:51 PM Jon Wayne Parrott ***@***.***> wrote: @remi <https://github.com/remi> totally up to you. Python uses indented_block because it keeps things simple and generally we can name the functions the same as the region tags (go also has similar go_func functionality). But it doesn't matter either way style-wise, it's just preference. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1353 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAABGAjFOL9RaMS-ADJx4ACYdW7VrWzYks5tS4hqgaJpZM4R9Yz_> .

-- Rebecca Taylor | Developer Programs Engineer | [email protected]

[theacodes]

Yep - hence my last comment- totally up to you. Within this repo there are samples that use both styles in the same file, even.

[beccasaurus]

Perfect, thanks! 🙏

On Thu, Feb 8, 2018 at 3:56 PM Jon Wayne Parrott ***@***.***> wrote: Yep - hence my last comment- totally up to you. Within this repo there are samples that use both styles in the same file, even. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1353 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAABGPSd8K25_5ohLcDYbAaod-wUYJjPks5tS4m7gaJpZM4R9Yz_> .

-- Rebecca Taylor | Developer Programs Engineer | [email protected]

[beccasaurus]

@dizcology I really, really struggle to easily understand what this sample is doing

It's not easy on the eyes & doesn't read like prose on the website IMO

Do you like this sample? Any ideas for ways to highlight parts TextAnnotation that developers want to know about in a more consumable, easy to read sample?

[beccasaurus]

For Ruby, I'm rolling with this:

  # image_path = "Google Cloud Storage URI, eg. 'gs://my-bucket/image.png'"

  require "google/cloud/vision"

  vision = Google::Cloud::Vision.new

  document = vision.document_text_detection(image_path).full_text_annotation

  puts "Full document text: #{document.text}"

  document.pages.each do |page|
    page.blocks.each  do |block|
      block.paragraphs.each do |paragraph|
        puts "Paragraph confidence: #{paragraph.confidence}"
        paragraph.words.each do |word|
          puts "\tWord confidence: #{word.confidence}"
          puts "\tWord text: #{word.symbols.map(&:text).join}"
          word.symbols.each do |symbol|
            puts "\t\tSymbol text: #{symbol.text}"
            puts "\t\tSymbol confidence: #{symbol.confidence}"
          end
        end
      end
    end
  end

I almost don't want to include anything that concatenates/joins text together to print it out (developers can figure that out?) ... but, at least in Ruby it's idiomatic and relatively readable to print out each word:

puts "\tWord text: #{word.symbols.map(&:text).join}"

The Python snippet includes:

• 2 Lists used to build up data to print
• 2 Strings used to build data to print
• Logic to extend Lists
• Also, 2 types of syntax are used to concatenate strings:

word_text = word_text + symbol.text

block_text += ' ' + word_text

^--- both should use += or not use += (should be consistent)

Thoughts?

[beccasaurus]

Also: I vote that the sample shows how to print out the WHOLE text without having to concatenate symbols⇒words⇒paragraphs⇒blocks⇒pages, because this is a very common use-case

^---- also, what is a block? ... I hope the docs make that clear, because it's not obvious to me ...

[beccasaurus]

ping @dizcology for thoughts

Also, would love to get this ready for merge ~ this comment is my only remaining question IIRC 😄

[beccasaurus]

Hey, @dizcology we can close this, right? Vision GA was merged #1427

[beccasaurus]

Closing PR /cc @dizcology