Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeError when running Storage notification polling exmaple. #1135

Merged
merged 12 commits into from
Sep 22, 2017

Conversation

BrandonY
Copy link
Contributor

@BrandonY BrandonY commented Sep 22, 2017

Looks like #1093 accidentally broke Storage's notification_polling.py example. Here's a fix.

Also, I cleaned up the formatting of the documentation a bit.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 22, 2017
@BrandonY BrandonY changed the title Pull from parent Fix TypeError when running Storage notification polling exmaple. Sep 22, 2017
configuring auth and installing dependencies. See the README's "Setup"
section.

2. Activate the Google Cloud Pub/Sub API, if you have not already done so.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you'll need to update all the numbers after this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, done.

@theacodes theacodes merged commit b94b7f4 into GoogleCloudPlatform:master Sep 22, 2017
@theacodes
Copy link
Contributor

Thanks, @BrandonY!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants