Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove datalab migration doc #10908

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

Linchin
Copy link
Contributor

@Linchin Linchin commented Nov 6, 2023

Description

Merge after internal change 579341078 is submitted.
Unblocks #10891.

Because one of datalab dependencies (pandas-profiling) deleted the older versions that datalab is using, we delete the datalab migration sample here.

Checklist

@Linchin Linchin requested review from chalmerlowe and a team as code owners November 6, 2023 17:53
Copy link

snippet-bot bot commented Nov 6, 2023

Here is the summary of changes.

You are about to delete 16 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: bigquery Issues related to the BigQuery API. labels Nov 6, 2023
@Linchin Linchin requested a review from shollyman November 6, 2023 17:54
@Linchin Linchin added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Nov 6, 2023
Copy link
Member

@rsamborski rsamborski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double checked couple random region_tags and it seems they are no longer published on c.g.c, so this should be fine to merge.

@Linchin Linchin merged commit 7b5fb7e into GoogleCloudPlatform:main Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants