Skip to content

Commit

Permalink
chore: update README and fix typos in attestation scripts (#203)
Browse files Browse the repository at this point in the history
Remove the README.rst.in until the README gen templates have been updated

Co-authored-by: Benson Kuang <[email protected]>
  • Loading branch information
2 people authored and rsamborski committed Nov 8, 2022
1 parent bb5a5f2 commit 60de4f1
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 30 deletions.
15 changes: 9 additions & 6 deletions kms/attestations/README.rst
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
.. This file is automatically generated. Do not edit this file directly.
Google Cloud Key Management Service Python Samples
===============================================================================

Expand All @@ -12,7 +10,7 @@ This directory contains samples for Google Cloud Key Management Service. The `Cl



.. _Google Cloud Key Management Service: https://cloud.google.com/kms/docs/
.. _Cloud Key Management Service: https://cloud.google.com/kms/docs/



Expand All @@ -25,11 +23,11 @@ Setup
Install Dependencies
++++++++++++++++++++

#. Clone python-docs-samples and change directory to the sample directory you want to use.
#. Clone python-kms and change directory to the sample directory you want to use.

.. code-block:: bash
$ git clone https://github.com/GoogleCloudPlatform/python-docs-samples.git
$ git clone https://github.com/googleapis/python-kms.git
#. Install `pip`_ and `virtualenv`_ if you do not already have them. You may want to refer to the `Python Development Environment Setup Guide`_ for Google Cloud Platform for instructions.

Expand All @@ -43,6 +41,11 @@ Install Dependencies
$ virtualenv env
$ source env/bin/activate
#. Install the dependencies needed to run the samples.

.. code-block:: bash
$ pip install -r requirements.txt
.. _pip: https://pip.pypa.io/
.. _virtualenv: https://virtualenv.pypa.io/
Expand Down Expand Up @@ -86,7 +89,7 @@ Verify attestations for keys generated by Cloud HSM
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

.. image:: https://gstatic.com/cloudssh/images/open-btn.png
:target: https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/GoogleCloudPlatform/python-docs-samples&page=editor&open_in_editor=samples/attestations/verify_attestation.py,samples/attestations/README.rst
:target: https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/googleapis/python-kms&page=editor&open_in_editor=samples/attestations/verify_attestation.py,samples/attestations/README.rst



Expand Down
23 changes: 0 additions & 23 deletions kms/attestations/README.rst.in

This file was deleted.

2 changes: 1 addition & 1 deletion kms/attestations/verify_attestation.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ def verify(attestation_file, bundle_file):
cert_obj = x509.load_pem_x509_certificate(
str(cert).encode('utf-8'), backends.default_backend())
try:
# Check if the data was signed by the private key assosicated
# Check if the data was signed by the private key associated
# with the public key in the certificate. The data should have
# been signed with PKCS1v15 padding.
cert_obj.public_key().verify(
Expand Down

0 comments on commit 60de4f1

Please sign in to comment.