Skip to content

Commit

Permalink
lint
Browse files Browse the repository at this point in the history
  • Loading branch information
@billyjacobson
billyjacobson committed Apr 30, 2020
1 parent 777d988 commit 068cdcf
Showing 1 changed file with 118 additions and 120 deletions.
238 changes: 118 additions & 120 deletions bigtable/metricscaler/metricscaler_test.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -32,169 +32,167 @@
BIGTABLE_ZONE = os.environ['BIGTABLE_ZONE']
SIZE_CHANGE_STEP = 3
INSTANCE_ID_FORMAT = 'metric-scale-test-{}'
BIGTABLE_INSTANCE = INSTANCE_ID_FORMAT.format(
uuid.uuid4())
BIGTABLE_DEV_INSTANCE = INSTANCE_ID_FORMAT.format(
uuid.uuid4())
BIGTABLE_INSTANCE = INSTANCE_ID_FORMAT.format(uuid.uuid4())
BIGTABLE_DEV_INSTANCE = INSTANCE_ID_FORMAT.format(uuid.uuid4())


# System tests to verify API calls succeed


def test_get_cpu_load():
assert float(get_cpu_load()) > 0.0
assert float(get_cpu_load()) > 0.0


def test_get_storage_utilization():
assert float(get_storage_utilization()) > 0.0
assert float(get_storage_utilization()) > 0.0


@pytest.fixture()
def instance():
cluster_id = BIGTABLE_INSTANCE
cluster_id = BIGTABLE_INSTANCE

client = bigtable.Client(project=PROJECT, admin=True)
client = bigtable.Client(project=PROJECT, admin=True)

serve_nodes = 3
storage_type = enums.StorageType.SSD
production = enums.Instance.Type.PRODUCTION
labels = {'prod-label': 'prod-label'}
instance = client.instance(BIGTABLE_INSTANCE, instance_type=production,
labels=labels)
serve_nodes = 3
storage_type = enums.StorageType.SSD
production = enums.Instance.Type.PRODUCTION
labels = {'prod-label': 'prod-label'}
instance = client.instance(BIGTABLE_INSTANCE, instance_type=production,
labels=labels)

if not instance.exists():
cluster = instance.cluster(cluster_id, location_id=BIGTABLE_ZONE,
serve_nodes=serve_nodes,
default_storage_type=storage_type)
instance.create(clusters=[cluster])
if not instance.exists():
cluster = instance.cluster(cluster_id, location_id=BIGTABLE_ZONE,
serve_nodes=serve_nodes,
default_storage_type=storage_type)
instance.create(clusters=[cluster])

yield
yield

instance.delete()
instance.delete()


@pytest.fixture()
def dev_instance():
cluster_id = BIGTABLE_DEV_INSTANCE
cluster_id = BIGTABLE_DEV_INSTANCE

client = bigtable.Client(project=PROJECT, admin=True)
client = bigtable.Client(project=PROJECT, admin=True)

storage_type = enums.StorageType.SSD
development = enums.Instance.Type.DEVELOPMENT
labels = {'dev-label': 'dev-label'}
instance = client.instance(BIGTABLE_DEV_INSTANCE,
instance_type=development,
labels=labels)
storage_type = enums.StorageType.SSD
development = enums.Instance.Type.DEVELOPMENT
labels = {'dev-label': 'dev-label'}
instance = client.instance(BIGTABLE_DEV_INSTANCE,
instance_type=development,
labels=labels)

if not instance.exists():
cluster = instance.cluster(cluster_id, location_id=BIGTABLE_ZONE,
default_storage_type=storage_type)
instance.create(clusters=[cluster])
if not instance.exists():
cluster = instance.cluster(cluster_id, location_id=BIGTABLE_ZONE,
default_storage_type=storage_type)
instance.create(clusters=[cluster])

yield
yield

instance.delete()
instance.delete()


def test_scale_bigtable(instance):
bigtable_client = bigtable.Client(admin=True)
bigtable_client = bigtable.Client(admin=True)

instance = bigtable_client.instance(BIGTABLE_INSTANCE)
instance.reload()
instance = bigtable_client.instance(BIGTABLE_INSTANCE)
instance.reload()

cluster = instance.cluster(BIGTABLE_INSTANCE)
cluster.reload()
original_node_count = cluster.serve_nodes
cluster = instance.cluster(BIGTABLE_INSTANCE)
cluster.reload()
original_node_count = cluster.serve_nodes

scale_bigtable(BIGTABLE_INSTANCE, BIGTABLE_INSTANCE, True)
scale_bigtable(BIGTABLE_INSTANCE, BIGTABLE_INSTANCE, True)

for n in range(10):
time.sleep(10)
cluster.reload()
new_node_count = cluster.serve_nodes
try:
assert (new_node_count == (original_node_count + SIZE_CHANGE_STEP))
except AssertionError:
if n == 9:
raise
for n in range(10):
time.sleep(10)
cluster.reload()
new_node_count = cluster.serve_nodes
try:
assert (new_node_count == (original_node_count + SIZE_CHANGE_STEP))
except AssertionError:
if n == 9:
raise

scale_bigtable(BIGTABLE_INSTANCE, BIGTABLE_INSTANCE, False)
scale_bigtable(BIGTABLE_INSTANCE, BIGTABLE_INSTANCE, False)

for n in range(10):
time.sleep(10)
cluster.reload()
final_node_count = cluster.serve_nodes
try:
assert final_node_count == original_node_count
except AssertionError:
if n == 9:
raise
for n in range(10):
time.sleep(10)
cluster.reload()
final_node_count = cluster.serve_nodes
try:
assert final_node_count == original_node_count
except AssertionError:
if n == 9:
raise


def test_handle_dev_instance(capsys, dev_instance):
with pytest.raises(ValueError):
scale_bigtable(BIGTABLE_DEV_INSTANCE, BIGTABLE_DEV_INSTANCE, True)
with pytest.raises(ValueError):
scale_bigtable(BIGTABLE_DEV_INSTANCE, BIGTABLE_DEV_INSTANCE, True)


@patch('time.sleep')
@patch('metricscaler.get_storage_utilization')
@patch('metricscaler.get_cpu_load')
@patch('metricscaler.scale_bigtable')
def test_main(scale_bigtable, get_cpu_load, get_storage_utilization, sleep):
SHORT_SLEEP = 5
LONG_SLEEP = 10

# Test okay CPU, okay storage utilization
get_cpu_load.return_value = 0.5
get_storage_utilization.return_value = 0.5

main(BIGTABLE_INSTANCE, BIGTABLE_INSTANCE, 0.6, 0.3, 0.6, SHORT_SLEEP,
LONG_SLEEP)
scale_bigtable.assert_not_called()
scale_bigtable.reset_mock()

# Test high CPU, okay storage utilization
get_cpu_load.return_value = 0.7
get_storage_utilization.return_value = 0.5
main(BIGTABLE_INSTANCE, BIGTABLE_INSTANCE, 0.6, 0.3, 0.6, SHORT_SLEEP,
LONG_SLEEP)
scale_bigtable.assert_called_once_with(BIGTABLE_INSTANCE,
BIGTABLE_INSTANCE, True)
scale_bigtable.reset_mock()

# Test low CPU, okay storage utilization
get_storage_utilization.return_value = 0.5
get_cpu_load.return_value = 0.2
main(BIGTABLE_INSTANCE, BIGTABLE_INSTANCE, 0.6, 0.3, 0.6, SHORT_SLEEP,
LONG_SLEEP)
scale_bigtable.assert_called_once_with(BIGTABLE_INSTANCE,
BIGTABLE_INSTANCE, False)
scale_bigtable.reset_mock()

# Test okay CPU, high storage utilization
get_cpu_load.return_value = 0.5
get_storage_utilization.return_value = 0.7

main(BIGTABLE_INSTANCE, BIGTABLE_INSTANCE, 0.6, 0.3, 0.6, SHORT_SLEEP,
LONG_SLEEP)
scale_bigtable.assert_called_once_with(BIGTABLE_INSTANCE,
BIGTABLE_INSTANCE, True)
scale_bigtable.reset_mock()

# Test high CPU, high storage utilization
get_cpu_load.return_value = 0.7
get_storage_utilization.return_value = 0.7
main(BIGTABLE_INSTANCE, BIGTABLE_INSTANCE, 0.6, 0.3, 0.6, SHORT_SLEEP,
LONG_SLEEP)
scale_bigtable.assert_called_once_with(BIGTABLE_INSTANCE,
BIGTABLE_INSTANCE, True)
scale_bigtable.reset_mock()

# Test low CPU, high storage utilization
get_cpu_load.return_value = 0.2
get_storage_utilization.return_value = 0.7
main(BIGTABLE_INSTANCE, BIGTABLE_INSTANCE, 0.6, 0.3, 0.6, SHORT_SLEEP,
LONG_SLEEP)
scale_bigtable.assert_called_once_with(BIGTABLE_INSTANCE,
BIGTABLE_INSTANCE, True)
scale_bigtable.reset_mock()
SHORT_SLEEP = 5
LONG_SLEEP = 10

# Test okay CPU, okay storage utilization
get_cpu_load.return_value = 0.5
get_storage_utilization.return_value = 0.5

main(BIGTABLE_INSTANCE, BIGTABLE_INSTANCE, 0.6, 0.3, 0.6, SHORT_SLEEP,
LONG_SLEEP)
scale_bigtable.assert_not_called()
scale_bigtable.reset_mock()

# Test high CPU, okay storage utilization
get_cpu_load.return_value = 0.7
get_storage_utilization.return_value = 0.5
main(BIGTABLE_INSTANCE, BIGTABLE_INSTANCE, 0.6, 0.3, 0.6, SHORT_SLEEP,
LONG_SLEEP)
scale_bigtable.assert_called_once_with(BIGTABLE_INSTANCE,
BIGTABLE_INSTANCE, True)
scale_bigtable.reset_mock()

# Test low CPU, okay storage utilization
get_storage_utilization.return_value = 0.5
get_cpu_load.return_value = 0.2
main(BIGTABLE_INSTANCE, BIGTABLE_INSTANCE, 0.6, 0.3, 0.6, SHORT_SLEEP,
LONG_SLEEP)
scale_bigtable.assert_called_once_with(BIGTABLE_INSTANCE,
BIGTABLE_INSTANCE, False)
scale_bigtable.reset_mock()

# Test okay CPU, high storage utilization
get_cpu_load.return_value = 0.5
get_storage_utilization.return_value = 0.7

main(BIGTABLE_INSTANCE, BIGTABLE_INSTANCE, 0.6, 0.3, 0.6, SHORT_SLEEP,
LONG_SLEEP)
scale_bigtable.assert_called_once_with(BIGTABLE_INSTANCE,
BIGTABLE_INSTANCE, True)
scale_bigtable.reset_mock()

# Test high CPU, high storage utilization
get_cpu_load.return_value = 0.7
get_storage_utilization.return_value = 0.7
main(BIGTABLE_INSTANCE, BIGTABLE_INSTANCE, 0.6, 0.3, 0.6, SHORT_SLEEP,
LONG_SLEEP)
scale_bigtable.assert_called_once_with(BIGTABLE_INSTANCE,
BIGTABLE_INSTANCE, True)
scale_bigtable.reset_mock()

# Test low CPU, high storage utilization
get_cpu_load.return_value = 0.2
get_storage_utilization.return_value = 0.7
main(BIGTABLE_INSTANCE, BIGTABLE_INSTANCE, 0.6, 0.3, 0.6, SHORT_SLEEP,
LONG_SLEEP)
scale_bigtable.assert_called_once_with(BIGTABLE_INSTANCE,
BIGTABLE_INSTANCE, True)
scale_bigtable.reset_mock()

0 comments on commit 068cdcf

Please sign in to comment.