Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Spanner): Add directed read samples #1939

Merged
merged 3 commits into from
Jan 8, 2024
Merged

feat(Spanner): Add directed read samples #1939

merged 3 commits into from
Jan 8, 2024

Conversation

ajupazhamayil
Copy link
Contributor

This is dependent on googleapis/google-cloud-php#6078
Once the dependent PR merged, need to update the composer.json file to match the google-cloud-php latest version.

@ajupazhamayil ajupazhamayil requested review from a team as code owners December 4, 2023 09:51
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Dec 4, 2023 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: spanner Issues related to the Spanner API. samples Issues that are directly related to samples. labels Dec 4, 2023
@vishwarajanand vishwarajanand added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 4, 2023
@ajupazhamayil ajupazhamayil removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 8, 2024
@ajupazhamayil ajupazhamayil enabled auto-merge (squash) January 8, 2024 10:29
vishwarajanand
vishwarajanand reviewed Jan 8, 2024
View reviewed changes
spanner/src/directed_read.php

namespace Google\Cloud\Samples\Spanner;

// [START spanner_directed_read]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this is the correct tag? Only C++ seems to have implemented this!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Its mentioned in the shared design doc.

vishwarajanand
vishwarajanand approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@vishwarajanand vishwarajanand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, approving to unblock.
Pls check the region_tag and run tests once before merge.

@ajupazhamayil ajupazhamayil merged commit 1148ff8 into main Jan 8, 2024
@ajupazhamayil ajupazhamayil deleted the directedReads branch January 8, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishwarajanand vishwarajanand vishwarajanand approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajupazhamayil @vishwarajanand