MSSQL: Fix Integration Test #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmikei
added
the
kokoro:force-run
stackdriver-instrumentation-release
removed
the
kokoro:force-run
qingling128
added
the
kokoro:force-run
stackdriver-instrumentation-release
removed
the
kokoro:force-run
…o mssql-integration-test-debug
…s-agent into mssql-integration-test-debug
schmikei
added
the
kokoro:force-run
stackdriver-instrumentation-release
removed
the
kokoro:force-run
schmikei
added
the
kokoro:force-run
stackdriver-instrumentation-release
removed
the
kokoro:force-run
schmikei
added
the
kokoro:force-run
stackdriver-instrumentation-release
removed
the
kokoro:force-run
schmikei
added
the
kokoro:force-run
stackdriver-instrumentation-release
removed
the
kokoro:force-run
schmikei
added
the
kokoro:force-run
stackdriver-instrumentation-release
removed
the
kokoro:force-run
schmikei
added
the
kokoro:force-run
stackdriver-instrumentation-release
removed
the
kokoro:force-run
schmikei
added
the
kokoro:force-run
stackdriver-instrumentation-release
removed
the
kokoro:force-run
|
@qingling128 This should fix the MSSQL integration tests that were blocking the release. Seeing the current failures don't appear to be related. I can continue to run kokoro if you'd like to be sure but just let me know!
|
schmikei
changed the title
…o mssql-integration-test-debug
schmikei
added
the
kokoro:force-run
stackdriver-instrumentation-release
removed
the
kokoro:force-run
integration_test/third_party_apps_data/applications/mssql/enable
Outdated
Show resolved
Hide resolved
qingling128
approved these changes
Jun 29, 2022
| @@ -38,11 +38,13 @@ expected_metrics: | |||
| monitored_resource: gce_instance | |||
| labels: {} | |||
| # v2 metrics | |||
| - type: workload.googleapis.com/sqlserver.user.connection.count # TODO: look into this metric type change | |||
| value_type: DOUBLE | |||
| - type: workload.googleapis.com/sqlserver.user.connection.count | |||
There was a problem hiding this comment.
For the records: we are ok with changing the expected type from DOUBLE to INT because the V2 mssql metrics was never released.
integration_test/third_party_apps_data/applications/mssql/metadata.yaml
Outdated
Show resolved
Hide resolved
igorpeshansky
approved these changes
Jun 29, 2022
integration_test/third_party_apps_data/applications/mssql/metadata.yaml
Outdated
Show resolved
Hide resolved
schmikei
added
the
kokoro:force-run
stackdriver-instrumentation-release
removed
the
kokoro:force-run
schmikei
added
the
kokoro:force-run
stackdriver-instrumentation-release
removed
the
kokoro:force-run
|
Both of the failed Kokoro checks (ops agent on I'm going to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were not run during merge and because of open-telemetry/opentelemetry-collector-contrib#9691, they needed to become different types.
Apologies for not catching it sooner! Should unblock anything that was relying on this being fixed!
http://b/237276968