Update Cloud Trace readme with troubleshooting for ServiceAccount annotation #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psx95
reviewed
Nov 30, 2022
psx95
reviewed
Nov 30, 2022
| @@ -38,7 +38,7 @@ spec: | |||
| spec: | |||
| containers: | |||
| - name: javashowcase-service | |||
| image: %REGISTRY_LOCATION%-docker.pkg.dev/%GCLOUD_PROJECT%/%CONTAINER_REGISTRY%/java-sample-service:latest | |||
| image: "%REGISTRY_LOCATION%-docker.pkg.dev/%GCLOUD_PROJECT%/%CONTAINER_REGISTRY%/java-sample-service:latest" | |||
There was a problem hiding this comment.
Curious: Did it work without the quotes ?
There was a problem hiding this comment.
Good question, I'm not sure how this was missed before. This sample merged a couple minutes before we added the CI check, so maybe it just snuck in. Will keep an eye on it
damemi
force-pushed
the
cloudtrace-serviceaccount-troubleshooting
branch
from
b45621f to
92d318c
Compare
psx95
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25