Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working example and consistent with Monitoring README #97

Merged
merged 1 commit into from
Sep 15, 2020
Merged

Working example and consistent with Monitoring README #97

merged 1 commit into from
Sep 15, 2020

Conversation

DazWilkin
Copy link
Contributor

Per #95 (comment) revision to the Trace example to remove the redundant WithProjectID(...) if running on GCP. The function is now explained under "Authentication".

The example referenced tracer.WithSpan(...) which appears incorrect; I looked at the GCP example and revised this with that example's self-executing function that includes a tracer.Start(...)

Feel free to ignore this PR; I offered to ensure both examples are consistent and this does that.

Copy link
Contributor

@nilebox nilebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants