Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate e2e tests Container Registry usage to Artifact Registry #882

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

aabmass
Copy link
Contributor

@aabmass aabmass commented Aug 15, 2024

  • Push images to GAR
  • Upgrading to latest test runner docker image which lives in GAR
  • Update wait-for-image.sh and build scripts that were coupled to gcr.

@aabmass aabmass changed the title Migrate e2e tests Container Registry usage to Artifact Repository Migrate e2e tests Container Registry usage to Artifact Registry Aug 15, 2024
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.80%. Comparing base (4caace7) to head (1dc155f).
Report is 35 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #882      +/-   ##
==========================================
+ Coverage   61.03%   61.80%   +0.76%     
==========================================
  Files          56       58       +2     
  Lines        5903     6063     +160     
==========================================
+ Hits         3603     3747     +144     
- Misses       2143     2156      +13     
- Partials      157      160       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aabmass aabmass force-pushed the gcr-migration branch 3 times, most recently from 2bedd82 to c1aabe1 Compare August 15, 2024 04:35
@aabmass aabmass marked this pull request as ready for review August 15, 2024 16:46
@aabmass aabmass requested a review from a team as a code owner August 15, 2024 16:46
@aabmass aabmass merged commit b8e9359 into GoogleCloudPlatform:main Aug 15, 2024
29 checks passed
@aabmass aabmass deleted the gcr-migration branch August 15, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants