Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge col-exporter-rewrite into main #295

Merged
merged 38 commits into from
Feb 2, 2022
Merged

merge col-exporter-rewrite into main #295

merged 38 commits into from
Feb 2, 2022

Conversation

dashpole
Copy link
Contributor

No description provided.

aabmass and others added 30 commits December 9, 2021 11:17
[Metrics Rewrite] attribute to label mapping
* [Metrics Rewrite] support for pdata Sum points

* update breaking-changes.md

* use concatentation instead of sprintf
* Fixes from merge.

* Fix tests.

* Clean up test cases, re-disable integration tests.

* Add summary descriptors and label descriptors.

* Fix lint issues.

* Some fixes from review.

* Remove metric import.

* Fixes from review.
- Update default config method
- Simplify some of my lack-of-go expertise.

* Add unit test for metric domains.

* Fixes from review.

* Add breaking changes.

* Fixes from review.

* Update context to be TODO.
* Add support for exponential histograms and exemplars.

* Fixes from review.

* Fixes from review.

* Fixes from discussion.
* [Metrics Rewrite] implement monitored resource mapping

* review fixes
* Initial implementation of create service time series.

* Add a test case for create service timeseries.

* Add logic to auto-detect project id if not configured.

* Fix from code review

* Fix resource to be one that has retention policy for integration tests.
* [Metrics Rewrite] add ExponentialHistogram fixture

* make tests deterministic

* few last changes

* close channel instead of sending a message
- There is a bug in upstream agent-metric-processor that sets incorrect units on usage metrics (GoogleCloudPlatform/opentelemetry-operations-collector#72)
- We update the expectations for inculsion of units in CreateTimeSeries
- We disable metric descriptors (for now).  Given the bug in agent-metric-processor, liekly ops-agent will need upstream fix for this first.
* Enable basic counter test.

* Enable delta counter metrics.

- Note: Delta counters are NOW fake-delta (i.e. cumulatives with limited time windows)

* Enable non-monotonic-sum integration test.

* Re-enable summary integration test and fix design issues in summary translation.

- Summary exports percentiles, not quantiles
- Percentiles should include similar double precision in the string.
* enable workloadapis prefix integration test.

* update unknown domain metrics expect.
* Add instrumentationLibraryToLabels method to metrics exporter.

BUG=https://b.corp.google.com/issues/210164355

* Remove custom_metrics_domains behaviour from metrics-exporter.
* remove dependency on go.opentelemetry.io/collector
@dashpole dashpole requested review from aabmass and punya January 31, 2022 18:47
@dashpole dashpole closed this Feb 2, 2022
@dashpole dashpole reopened this Feb 2, 2022
@dashpole dashpole merged commit 7338096 into main Feb 2, 2022
@dashpole dashpole deleted the col-exporter-rewrite branch February 2, 2022 19:10
@dashpole dashpole restored the col-exporter-rewrite branch February 2, 2022 19:54
dashpole added a commit that referenced this pull request Feb 2, 2022
@dashpole dashpole deleted the col-exporter-rewrite branch February 2, 2022 21:26
@dashpole dashpole restored the col-exporter-rewrite branch February 3, 2022 14:45
@dashpole dashpole deleted the col-exporter-rewrite branch February 3, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants