Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to otel 0.14 #120

Merged
merged 6 commits into from
Nov 24, 2020
Merged

Update to otel 0.14 #120

merged 6 commits into from
Nov 24, 2020

Conversation

adlerhurst
Copy link
Contributor

Hi guys

As i was testing otel 0.14 i updated your project. Maybe the changes work with you.

Greets from Switzerland

@adlerhurst adlerhurst mentioned this pull request Nov 23, 2020
Closed
dashpole
dashpole reviewed Nov 24, 2020
View reviewed changes
Copy link
Contributor

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help! Just a few nits.

dashpole
dashpole reviewed Nov 24, 2020
View reviewed changes
@adlerhurst
Copy link
Contributor Author

hi @dashpole

thanks for your review. i've corrected the files.

I've also changed the used otel version in.
https://github.com/adlerhurst/opentelemetry-operations-go/blob/20c83ede56cac1b365904bda780e79bba9c9cf46/exporter/trace/version.go#L20
and
https://github.com/adlerhurst/opentelemetry-operations-go/blob/20c83ede56cac1b365904bda780e79bba9c9cf46/exporter/metric/version.go#L20

@dashpole dashpole self-assigned this Nov 24, 2020
@dashpole dashpole closed this Nov 24, 2020
@dashpole dashpole reopened this Nov 24, 2020
@dashpole
Copy link
Contributor

closed/reopened to poke tests

@dashpole dashpole merged commit 540edb3 into GoogleCloudPlatform:master Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dashpole dashpole dashpole approved these changes

Assignees

@dashpole dashpole

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adlerhurst @dashpole