Skip to content

Commit

Permalink
Remove internal/ prefix for integrationtest (#288)
Browse files Browse the repository at this point in the history
  • Loading branch information
punya authored Jan 25, 2022
1 parent e2e6a39 commit b904c05
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions exporter/collector/integrationtests.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ and compare requests against recorded expectation fixtures. Currently, these tes
metrics.

The fixtures are located in the [`testdata/fixtures`][fixtures] directory and registered in
[`internal/integrationtest/testcases.go`][testcases].
[`integrationtest/testcases.go`][testcases].

## Running Tests

Expand Down Expand Up @@ -81,17 +81,17 @@ To add a new test:

This is how the Ops Agent fixtures were generated.

1. Add an entry in [`internal/integrationtest/testcases.go`][testcases].
1. Add an entry in [`integrationtest/testcases.go`][testcases].
1. Run the script to record the expectation fixture. This will contain the expected requests
that the exporter makes to GCP services:

```sh
cd internal/integrationtest
cd integrationtest
go run cmd/recordfixtures/main.go
```

The generated file is a JSON encoded
[`MetricExpectFixture`](internal/integrationtest/fixtures.proto#L21) protobuf message.
[`MetricExpectFixture`](integrationtest/fixtures.proto#L21) protobuf message.

See [#229](https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/229) for an
example PR.
Expand All @@ -107,4 +107,4 @@ If you need to see the build logs because tests are failing, just ask someone to
with you.

[fixtures]: testdata/fixtures
[testcases]: internal/integrationtest/testcases.go
[testcases]: integrationtest/testcases.go

0 comments on commit b904c05

Please sign in to comment.