Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kokoro config for standard environment #648

Closed
wants to merge 1 commit into from
Closed

Add Kokoro config for standard environment #648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .kokoro/appengine-datastore-flex.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# Format: //devtools/kokoro/config/proto/build.proto
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idea (feel free to ignore): maybe create an appengine directory to make things a little easier to find?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to add a few tests first to make sure they run as expected. And then worry about duplication and folders.


# Download secrets from Cloud Storage.
gfile_resources: "/bigstore/cloud-devrel-kokoro-resources/nodejs-docs-samples"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be moved to a common.cfg file, then it wouldn't need to be copied into every .cfg file.


# Tell the trampoline which build file to use.
env_vars: {
key: "TRAMPOLINE_BUILD_FILE"
value: "github/nodejs-docs-samples/.kokoro/appengine.sh"
}

# Set GAE environment
env_vars: {
key: "APPENGINE_ENVIRONMENT"
value: "flexible"
}
6 changes: 6 additions & 0 deletions .kokoro/appengine-datastore.cfg → .kokoro/appengine-datastore-standard.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,9 @@ env_vars: {
key: "TRAMPOLINE_BUILD_FILE"
value: "github/nodejs-docs-samples/.kokoro/appengine-datastore.sh"
}

# Set GAE environment
env_vars: {
key: "APPENGINE_ENVIRONMENT"
value: "standard"
}
6 changes: 3 additions & 3 deletions .kokoro/appengine-datastore.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
export GCLOUD_PROJECT=nodejs-docs-samples-tests

export NODE_ENV=development
export GAE_VERSION=appengine-datastore-flexible
export GAE_VERSION=appengine-datastore-${APPENGINE_ENVIRONMENT}

# Register post-test cleanup
function cleanup {
Expand All @@ -41,9 +41,9 @@ gcloud config set project $GCLOUD_PROJECT


# Deploy the app
gcloud app deploy app.flexible.yaml --version $GAE_VERSION --no-promote --quiet
gcloud app deploy app.${APPENGINE_ENVIRONMENT}.yaml --version $GAE_VERSION --no-promote --quiet
if [ -e "worker.yaml" ]; then
gcloud app deploy worker.yaml --version ${GAE_VERSION}-worker --no-promote --quiet
gcloud app deploy worker.yaml --version ${GAE_VERSION} --no-promote --quiet
fi


Expand Down