Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hello world tests on CircleCi #637

Merged
merged 2 commits into from
Jun 5, 2018
Merged

Fix hello world tests on CircleCi #637

merged 2 commits into from
Jun 5, 2018

Conversation

fhinkel
Copy link
Contributor

@fhinkel fhinkel commented Jun 5, 2018

We split the hello world sample in standard and flex. Updating the path to those two in CircleCi config.

Drive-by fix: make the tests pass in both these folders.

@codecov
Copy link

codecov bot commented Jun 5, 2018

Codecov Report

Merging #637 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #637   +/-   ##
=======================================
  Coverage   48.52%   48.52%           
=======================================
  Files           1        1           
  Lines          68       68           
=======================================
  Hits           33       33           
  Misses         35       35

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81aecc3...dac7efd. Read the comment docs.

@fhinkel fhinkel requested a review from JustinBeckwith June 5, 2018 18:49
@fhinkel fhinkel merged commit a2268f4 into master Jun 5, 2018
@jmdobry jmdobry deleted the FixHelloWorld branch June 27, 2018 22:25
ace-n pushed a commit that referenced this pull request Nov 17, 2022
ace-n pushed a commit that referenced this pull request Nov 17, 2022
ace-n pushed a commit that referenced this pull request Nov 17, 2022
ace-n pushed a commit that referenced this pull request Nov 17, 2022
ace-n pushed a commit that referenced this pull request Nov 17, 2022
ahrarmonsur pushed a commit that referenced this pull request Nov 18, 2022
🤖 I have created a release \*beep\* \*boop\* 
---
## [3.1.0](https://github.com/googleapis/nodejs-dialogflow/compare/v3.0.0...v3.1.0) (2020-07-10)


### Features

* adds projectAgentEnvironmentPathTemplate and projectAgentEnvironmentUserSessionContextPathTemplate ([c204d9c](https://github.com/googleapis/nodejs-dialogflow/commit/c204d9cd7d9f121404b15783b8da5a451a671748))


### Bug Fixes

* typeo in nodejs .gitattribute ([#639](https://github.com/googleapis/nodejs-dialogflow/issues/639)) ([558aad8](https://github.com/googleapis/nodejs-dialogflow/commit/558aad81af74888516db9667f4a4e7b56cd3d3ba))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
ahrarmonsur pushed a commit that referenced this pull request Nov 18, 2022
🤖 I have created a release \*beep\* \*boop\* 
---
## [3.1.0](https://github.com/googleapis/nodejs-dialogflow/compare/v3.0.0...v3.1.0) (2020-07-10)


### Features

* adds projectAgentEnvironmentPathTemplate and projectAgentEnvironmentUserSessionContextPathTemplate ([c204d9c](https://github.com/googleapis/nodejs-dialogflow/commit/c204d9cd7d9f121404b15783b8da5a451a671748))


### Bug Fixes

* typeo in nodejs .gitattribute ([#639](https://github.com/googleapis/nodejs-dialogflow/issues/639)) ([558aad8](https://github.com/googleapis/nodejs-dialogflow/commit/558aad81af74888516db9667f4a4e7b56cd3d3ba))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
NimJay pushed a commit that referenced this pull request Nov 18, 2022
🤖 I have created a release \*beep\* \*boop\* 
---
## [3.1.0](https://github.com/googleapis/nodejs-dialogflow/compare/v3.0.0...v3.1.0) (2020-07-10)


### Features

* adds projectAgentEnvironmentPathTemplate and projectAgentEnvironmentUserSessionContextPathTemplate ([c204d9c](https://github.com/googleapis/nodejs-dialogflow/commit/c204d9cd7d9f121404b15783b8da5a451a671748))


### Bug Fixes

* typeo in nodejs .gitattribute ([#639](https://github.com/googleapis/nodejs-dialogflow/issues/639)) ([558aad8](https://github.com/googleapis/nodejs-dialogflow/commit/558aad81af74888516db9667f4a4e7b56cd3d3ba))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants