Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update index.js #568

Closed
wants to merge 1 commit into from
Closed

Update index.js #568

wants to merge 1 commit into from

Conversation

labtopia
Copy link
Contributor

Per b/73223200, "The "helloGCSGeneric" function name should be "helloGCS" according to deploy command."

@ace-n
Copy link
Contributor

ace-n commented Feb 13, 2018

There are two helloGCS functions in that file. Perhaps this should be fixed in the docs instead? (Change the command-line sample to use helloGCSGeneric instead of helloGCS.)

ace-n
ace-n suggested changes Feb 13, 2018
View reviewed changes
Copy link
Contributor

@ace-n ace-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per my comment above.

@labtopia labtopia closed this Feb 13, 2018
ahrarmonsur pushed a commit that referenced this pull request Nov 8, 2022
@JustinBeckwith
chore: remove duplicate alert samples (#568)
eb0f066
@ahrarmonsur ahrarmonsur mentioned this pull request Nov 8, 2022
Merged
ace-n pushed a commit that referenced this pull request Nov 10, 2022
@JustinBeckwith
chore: remove duplicate alert samples (#568)
12ed444
@telpirion telpirion mentioned this pull request Nov 16, 2022
Merged
telpirion pushed a commit that referenced this pull request Nov 16, 2022
@alexander-fenster @bcoe @xiaozhenliu-gg5
feat!: drop node8 support, support for async iterators (#568)
47bc245 
* feat!: drop node8 support, support for async iterators

BREAKING CHANGE: The library now supports Node.js v10+. The last version to support Node.js v8 is tagged legacy-8 on NPM.

New feature: methods with pagination now support async iteration.

* fix tests & linter

Co-authored-by: Benjamin E. Coe <[email protected]>
Co-authored-by: Xiaozhen Liu <[email protected]>
grayside pushed a commit that referenced this pull request Nov 16, 2022
@release-please
chore(main): release 4.2.0 (#569)
4771ee7 
🤖 I have created a release *beep* *boop*
---


## [4.2.0](googleapis/nodejs-cloud-container@v4.1.3...v4.2.0) (2022-09-22)


### Features

* Added High Throughput Logging API for Google Kubernetes Engine ([#571](googleapis/nodejs-cloud-container#571)) ([588b19a](googleapis/nodejs-cloud-container@588b19a))


### Bug Fixes

* Preserve default values in x-goog-request-params header ([#568](googleapis/nodejs-cloud-container#568)) ([575531f](googleapis/nodejs-cloud-container@575531f))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
grayside pushed a commit that referenced this pull request Nov 16, 2022
@release-please
chore(main): release 4.2.0 (#569)
d141ccc 
🤖 I have created a release *beep* *boop*
---


## [4.2.0](googleapis/nodejs-cloud-container@v4.1.3...v4.2.0) (2022-09-22)


### Features

* Added High Throughput Logging API for Google Kubernetes Engine ([#571](googleapis/nodejs-cloud-container#571)) ([588b19a](googleapis/nodejs-cloud-container@588b19a))


### Bug Fixes

* Preserve default values in x-goog-request-params header ([#568](googleapis/nodejs-cloud-container#568)) ([575531f](googleapis/nodejs-cloud-container@575531f))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
grayside pushed a commit that referenced this pull request Nov 16, 2022
@release-please
chore(main): release 4.2.0 (#569)
45ed44c 
🤖 I have created a release *beep* *boop*
---


## [4.2.0](googleapis/nodejs-cloud-container@v4.1.3...v4.2.0) (2022-09-22)


### Features

* Added High Throughput Logging API for Google Kubernetes Engine ([#571](googleapis/nodejs-cloud-container#571)) ([588b19a](googleapis/nodejs-cloud-container@588b19a))


### Bug Fixes

* Preserve default values in x-goog-request-params header ([#568](googleapis/nodejs-cloud-container#568)) ([575531f](googleapis/nodejs-cloud-container@575531f))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@release-please
chore(main): release 4.2.0 (#569)
5efe9ba 
🤖 I have created a release *beep* *boop*
---


## [4.2.0](googleapis/nodejs-cloud-container@v4.1.3...v4.2.0) (2022-09-22)


### Features

* Added High Throughput Logging API for Google Kubernetes Engine ([#571](googleapis/nodejs-cloud-container#571)) ([588b19a](googleapis/nodejs-cloud-container@588b19a))


### Bug Fixes

* Preserve default values in x-goog-request-params header ([#568](googleapis/nodejs-cloud-container#568)) ([575531f](googleapis/nodejs-cloud-container@575531f))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
grayside pushed a commit that referenced this pull request Nov 17, 2022
@release-please @grayside
chore(main): release 4.2.0 (#569)
d70e1bd 
🤖 I have created a release *beep* *boop*
---


## [4.2.0](googleapis/nodejs-cloud-container@v4.1.3...v4.2.0) (2022-09-22)


### Features

* Added High Throughput Logging API for Google Kubernetes Engine ([#571](googleapis/nodejs-cloud-container#571)) ([588b19a](googleapis/nodejs-cloud-container@588b19a))


### Bug Fixes

* Preserve default values in x-goog-request-params header ([#568](googleapis/nodejs-cloud-container#568)) ([575531f](googleapis/nodejs-cloud-container@575531f))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ahrarmonsur pushed a commit that referenced this pull request Nov 17, 2022
@release-please
chore(main): release 4.2.0 (#569)
fe03ac2 
🤖 I have created a release *beep* *boop*
---


## [4.2.0](googleapis/nodejs-cloud-container@v4.1.3...v4.2.0) (2022-09-22)


### Features

* Added High Throughput Logging API for Google Kubernetes Engine ([#571](googleapis/nodejs-cloud-container#571)) ([588b19a](googleapis/nodejs-cloud-container@588b19a))


### Bug Fixes

* Preserve default values in x-goog-request-params header ([#568](googleapis/nodejs-cloud-container#568)) ([575531f](googleapis/nodejs-cloud-container@575531f))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ahrarmonsur pushed a commit that referenced this pull request Nov 18, 2022
@vernig @gverni
docs: correct typo in comment (#568)
535af2b 
Using a sessionId as number, it causes the following error in
`peg$parsetemplate`:
input.charCodeAt is not a function

Fixes #277

Co-authored-by: Giuseppe Verni <[email protected]>
ahrarmonsur pushed a commit that referenced this pull request Nov 18, 2022
@vernig @gverni
docs: correct typo in comment (#568)
3733761 
Using a sessionId as number, it causes the following error in
`peg$parsetemplate`:
input.charCodeAt is not a function

Fixes #277

Co-authored-by: Giuseppe Verni <[email protected]>
@ahrarmonsur ahrarmonsur mentioned this pull request Nov 18, 2022
Merged
NimJay pushed a commit that referenced this pull request Nov 18, 2022
@vernig @gverni @NimJay
docs: correct typo in comment (#568)
0595558 
Using a sessionId as number, it causes the following error in
`peg$parsetemplate`:
input.charCodeAt is not a function

Fixes #277

Co-authored-by: Giuseppe Verni <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ace-n ace-n ace-n requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@labtopia @ace-n