-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DLP quickstart + fix incorrect comments #442
Merged
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,13 +31,13 @@ function inspectString (string, minLikelihood, maxFindings, infoTypes, includeQu | |
// const string = 'My name is Gary and my email is [email protected]'; | ||
|
||
// The minimum likelihood required before returning a match | ||
// const minLikelihood = LIKELIHOOD_UNSPECIFIED; | ||
// const minLikelihood = 'LIKELIHOOD_UNSPECIFIED'; | ||
|
||
// The maximum number of findings to report (0 = server maximum) | ||
// const maxFindings = 0; | ||
|
||
// The infoTypes of information to match | ||
// const infoTypes = ['US_MALE_NAME', 'US_FEMALE_NAME']; | ||
// const infoTypes = [{ name: 'US_MALE_NAME', name: 'US_FEMALE_NAME' }]; | ||
|
||
// Whether to include the matching string | ||
// const includeQuote = true; | ||
|
@@ -91,13 +91,13 @@ function inspectFile (filepath, minLikelihood, maxFindings, infoTypes, includeQu | |
// const fileName = 'path/to/image.png'; | ||
|
||
// The minimum likelihood required before returning a match | ||
// const minLikelihood = LIKELIHOOD_UNSPECIFIED; | ||
// const minLikelihood = 'LIKELIHOOD_UNSPECIFIED'; | ||
|
||
// The maximum number of findings to report (0 = server maximum) | ||
// const maxFindings = 0; | ||
|
||
// The infoTypes of information to match | ||
// const infoTypes = ['US_MALE_NAME', 'US_FEMALE_NAME']; | ||
// const infoTypes = [{ name: 'US_MALE_NAME' }, { name: 'US_FEMALE_NAME' }]; | ||
|
||
// Whether to include the matching string | ||
// const includeQuote = true; | ||
|
@@ -158,13 +158,13 @@ function promiseInspectGCSFile (bucketName, fileName, minLikelihood, maxFindings | |
// const fileName = 'my-image.png'; | ||
|
||
// The minimum likelihood required before returning a match | ||
// const minLikelihood = LIKELIHOOD_UNSPECIFIED; | ||
// const minLikelihood = 'LIKELIHOOD_UNSPECIFIED'; | ||
|
||
// The maximum number of findings to report (0 = server maximum) | ||
// const maxFindings = 0; | ||
|
||
// The infoTypes of information to match | ||
// const infoTypes = ['US_MALE_NAME', 'US_FEMALE_NAME']; | ||
// const infoTypes = [{ name: 'US_MALE_NAME' }, { name: 'US_FEMALE_NAME' }]; | ||
|
||
// Get reference to the file to be inspected | ||
const storageItems = { | ||
|
@@ -232,13 +232,13 @@ function eventInspectGCSFile (bucketName, fileName, minLikelihood, maxFindings, | |
// const fileName = 'my-image.png'; | ||
|
||
// The minimum likelihood required before returning a match | ||
// const minLikelihood = LIKELIHOOD_UNSPECIFIED; | ||
// const minLikelihood = 'LIKELIHOOD_UNSPECIFIED'; | ||
|
||
// The maximum number of findings to report (0 = server maximum) | ||
// const maxFindings = 0; | ||
|
||
// The infoTypes of information to match | ||
// const infoTypes = ['US_MALE_NAME', 'US_FEMALE_NAME']; | ||
// const infoTypes = [{ name: 'US_MALE_NAME' }, { name: 'US_FEMALE_NAME' }]; | ||
|
||
// Get reference to the file to be inspected | ||
const storageItems = { | ||
|
@@ -320,13 +320,13 @@ function inspectDatastore (projectId, namespaceId, kind, minLikelihood, maxFindi | |
// const kind = 'Person'; | ||
|
||
// The minimum likelihood required before returning a match | ||
// const minLikelihood = LIKELIHOOD_UNSPECIFIED; | ||
// const minLikelihood = 'LIKELIHOOD_UNSPECIFIED'; | ||
|
||
// The maximum number of findings to report (0 = server maximum) | ||
// const maxFindings = 0; | ||
|
||
// The infoTypes of information to match | ||
// const infoTypes = ['US_MALE_NAME', 'US_FEMALE_NAME']; | ||
// const infoTypes = [{ name: 'US_MALE_NAME' }, { name: 'US_FEMALE_NAME' }]; | ||
|
||
// Get reference to the file to be inspected | ||
const storageItems = { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,77 @@ | ||
/** | ||
* Copyright 2017, Google, Inc. | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
'use strict'; | ||
|
||
// [START quickstart] | ||
// Imports the Google Cloud Data Loss Prevention library | ||
const DLP = require('@google-cloud/dlp'); | ||
|
||
// Instantiates a client | ||
const dlp = DLP(); | ||
|
||
// The string to inspect | ||
const string = 'Robert Frost'; | ||
|
||
// The minimum likelihood required before returning a match | ||
const minLikelihood = 'LIKELIHOOD_UNSPECIFIED'; | ||
|
||
// The maximum number of findings to report (0 = server maximum) | ||
const maxFindings = 0; | ||
|
||
// The infoTypes of information to match | ||
const infoTypes = [ | ||
{ name: 'US_MALE_NAME' }, | ||
{ name: 'US_FEMALE_NAME' } | ||
]; | ||
|
||
// Whether to include the matching string | ||
const includeQuote = true; | ||
|
||
// Construct items to inspect | ||
const items = [{ type: 'text/plain', value: string }]; | ||
|
||
// Construct request | ||
const request = { | ||
inspectConfig: { | ||
infoTypes: infoTypes, | ||
minLikelihood: minLikelihood, | ||
maxFindings: maxFindings, | ||
includeQuote: includeQuote | ||
}, | ||
items: items | ||
}; | ||
|
||
// Run request | ||
dlp.inspectContent(request) | ||
.then((response) => { | ||
const findings = response[0].results[0].findings; | ||
if (findings.length > 0) { | ||
console.log(`Findings:`); | ||
findings.forEach((finding) => { | ||
if (includeQuote) { | ||
console.log(`\tQuote: ${finding.quote}`); | ||
} | ||
console.log(`\tInfo type: ${finding.infoType.name}`); | ||
console.log(`\tLikelihood: ${finding.likelihood}`); | ||
}); | ||
} else { | ||
console.log(`No findings.`); | ||
} | ||
}) | ||
.catch((err) => { | ||
console.log(`Error in inspectString: ${err.message || err}`); | ||
}); | ||
// [END quickstart] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
/** | ||
* Copyright 2017, Google, Inc. | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
'use strict'; | ||
|
||
const path = require('path'); | ||
const test = require('ava'); | ||
const tools = require('@google-cloud/nodejs-repo-tools'); | ||
|
||
const cmd = 'node quickstart'; | ||
const cwd = path.join(__dirname, `..`); | ||
|
||
test.before(tools.checkCredentials); | ||
|
||
test(`should run`, async (t) => { | ||
const output = await tools.runAsync(cmd, cwd); | ||
t.regex(output, /Info type: US_MALE_NAME/); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use
console.error
, otherwise LGTM