Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move composer code out of functions folder #1870

Merged
merged 3 commits into from
Jun 11, 2020
Merged

Move composer code out of functions folder #1870

merged 3 commits into from
Jun 11, 2020

Conversation

leahecole
Copy link
Contributor

fixes internal bug b/156988611

@leahecole leahecole requested a review from ace-n June 11, 2020 18:22
@leahecole leahecole requested review from fhinkel and sofisl as code owners June 11, 2020 18:22
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 11, 2020
ace-n
ace-n approved these changes Jun 11, 2020
View reviewed changes
Copy link
Contributor

@ace-n ace-n left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! 🙂

@fhinkel
Copy link
Contributor

fhinkel commented Jun 11, 2020

The test configs need to be moved, too. And you need to move them in g3.
https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/master/.kokoro/functions/composer-storage-trigger.cfg

@leahecole leahecole requested a review from grant as a code owner June 11, 2020 20:55
@grant grant removed their request for review June 11, 2020 21:01
@fhinkel fhinkel added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 11, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 11, 2020
@leahecole leahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 11, 2020
@leahecole
Copy link
Contributor Author

I think the force run started before I submitted the CL - I submitted it now and hopefully things pass 🤞

@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 11, 2020
@leahecole leahecole merged commit cc55822 into master Jun 11, 2020
@fhinkel fhinkel deleted the move_composer_functions branch November 5, 2020 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhinkel fhinkel fhinkel approved these changes

@ace-n ace-n ace-n approved these changes

@sofisl sofisl Awaiting requested review from sofisl

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@leahecole @fhinkel @ace-n @googlebot @kokoro-team