Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: require node 10 in engines field #1723

Merged
merged 3 commits into from
Apr 18, 2020
Merged

feat!: require node 10 in engines field #1723

merged 3 commits into from
Apr 18, 2020

Conversation

sofisl
Copy link
Collaborator

@sofisl sofisl commented Apr 17, 2020

No description provided.

@sofisl sofisl requested review from fhinkel and bcoe April 17, 2020 01:34
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 17, 2020
@fhinkel
Copy link
Contributor

fhinkel commented Apr 18, 2020

Why the ! in the commit message?

@fhinkel fhinkel merged commit e299924 into GoogleCloudPlatform:master Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhinkel fhinkel fhinkel approved these changes

@bcoe bcoe Awaiting requested review from bcoe

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sofisl @fhinkel @googlebot