Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing region tags to functions/tips/scopeDemo #2959

Closed
ace-n opened this issue Jan 3, 2023 · 0 comments · Fixed by #2960
Closed

Add missing region tags to functions/tips/scopeDemo #2959

ace-n opened this issue Jan 3, 2023 · 0 comments · Fixed by #2960
Assignees
@ace-n
Labels
api: cloudfunctions Issues related to the Cloud Run functions API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@ace-n
Copy link
Contributor

ace-n commented Jan 3, 2023

This build is erroring out due to missing region tags.

We should add those tags to fix the build.
@ace-n ace-n added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. api: cloudfunctions Issues related to the Cloud Run functions API. labels Jan 3, 2023
@ace-n ace-n self-assigned this Jan 3, 2023
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jan 3, 2023
ace-n pushed a commit that referenced this issue Jan 3, 2023
fix(functions): add missing region tags to test
151c254 
Fixes #2959
@ace-n ace-n mentioned this issue Jan 3, 2023
Merged
ace-n pushed a commit that referenced this issue Jan 3, 2023
fix(functions): add missing region tags to test
7f1cce8 
Fixes #2959
ace-n pushed a commit that referenced this issue Jan 3, 2023
fix(functions): fix CI failures (#2960)
e0f33be 
* fix(functions): add missing region tags to test

Fixes #2959

* Fix lint issue
@snyk-bot snyk-bot mentioned this issue Jan 10, 2023
Open
@ninadhatkar ninadhatkar mentioned this issue Dec 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ace-n ace-n

Labels
api: cloudfunctions Issues related to the Cloud Run functions API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(functions): fix CI failures GoogleCloudPlatform/nodejs-docs-samples
1 participant
@ace-n