Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

functions/billing: test failure preventing PR merges #1985 #1988

Closed
engelke opened this issue Sep 28, 2020 · 2 comments · Fixed by #1990
Closed

functions/billing: test failure preventing PR merges #1985 #1988

engelke opened this issue Sep 28, 2020 · 2 comments · Fixed by #1990
Assignees
@ace-n
Labels
api: cloudfunctions Issues related to the Cloud Run functions API. lang: nodejs Issues specific to JavaScript or TypeScript. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. 🚨 This issue needs some love. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@engelke
Copy link
Contributor

engelke commented Sep 28, 2020

This test appears to have been failing for at least six months. Latest failure log has this:

1) "before all" hook in "{root}":
 Error: Invalid Credentials
  at Gaxios._request (node_modules/gaxios/build/src/gaxios.js:89:23)
  at process._tickCallback (internal/process/next_tick.js:68:7)
@engelke engelke added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. samples Issues that are directly related to samples. lang: nodejs Issues specific to JavaScript or TypeScript. labels Sep 28, 2020
@product-auto-label product-auto-label bot added the api: cloudfunctions Issues related to the Cloud Run functions API. label Sep 28, 2020
@grant
Copy link
Contributor

grant commented Sep 30, 2020 •
edited
Loading

I have observed this issue too.

I'd suggest disabling the test until it's more reliable.

CC @ace-n

@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Oct 5, 2020
@ace-n
Copy link
Contributor

ace-n commented Oct 6, 2020 •
edited
Loading

Test is no longer required, but #1990 should fix this.

@ace-n ace-n mentioned this issue Oct 6, 2020
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Oct 7, 2020
(Maybe) Fix broken billing sample (#1990)
02b9c02 
Fixes #1988
@ace-n ace-n mentioned this issue Oct 7, 2020
Closed
This was referenced Jan 11, 2022
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Mar 20, 2022
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ace-n ace-n

Labels
api: cloudfunctions Issues related to the Cloud Run functions API. lang: nodejs Issues specific to JavaScript or TypeScript. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. 🚨 This issue needs some love. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(Maybe) Fix broken billing sample GoogleCloudPlatform/nodejs-docs-samples
4 participants
@engelke @grant @ace-n @yoshi-automation