Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup: add region tags to yaml and sh #684
cleanup: add region tags to yaml and sh #684
Changes from 8 commits
a3fa2a7
7770cf9
5e7efb2
4d05d81
2a17e74
d26fd6d
e7bd41a
5d7a521
49b5b9c
1bab709
2d5a1df
06e8cdf
b1676dc
8e49161
165438e
b3e6104
b49d175
1a23ae1
5a8a8ed
318a04b
f9714de
07bfebf
02ac49d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue:
I noticed that we're adding region tags to file YAML files in
kubernetes-manifests/
. All these YAML files get concatenated into one file,release/kubernetes-manifests.yaml
, when we create a new release.So, for instance, this
# [START gke_kubernetes_manifests_adservice_deployment_adservice]
region tag would exist here and in the
release/kubernetes-manifests.yaml
file.Will this create any problems (having a region tag show up in two places)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ooooh good point.
this will cause a problem, since we shouldn't have duplicate region tags (with the same language, in this case yaml)
I'll try to see a workaround, thanks for bringing this up!!
I think the make-release-artifacts.sh can be edited to remove the tags (I don't think we need to have them in the release manifests)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. Adding code to remove lines look like
# [START ... ]
and# [END ...
inmake-release-artifacts.sh
might be the best solution.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed this! I added 2 lines for the kubernetes and istio manifest section.
For example here
finds lines that start with
# [
and deletes itThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks so much for adding this in. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after discussion with Megan, I edited make-release-artifacts.sh to add region tags around the
release/kubernetes-manifests.yaml
and therelease/istio-manifests.yaml