Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use skaffold modules & update relevant docs #609

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

NimJay
Copy link
Collaborator

@NimJay NimJay commented Oct 7, 2021

Fixes #492.

Change summary:
This pull-request:

  • splits the existing contents of skaffold.yaml into two modules: app; and loadgenerator.
    • We can now run something like skaffold run ... --module=app to run this sample app without the loadbalancer.
  • updates docs accordingly (see this comment from Bank of Anthos that confirms that we need skaffold 1.27+).

Additional Notes

  • Running skaffold run or skaffold dev will still behave the same as it did before (i.e., run all microservices).
  • Unlike with Bank of Anthos, we don't have modules for backend, frontend, setup, and db.
    • The reason: I don't imagine anyone wanting to run just the front-end or just the back-end (for this sample app). But I do imagine someone wanting to run this sample app without the loadbalancer.
    • Plus, I think we only really need 2 modules to showcase this skaffold feature.
    • I am very open to changing this, so please provide suggestions. :)

Tested 👍
I have tested the following commands and things work as expected:

  • skaffold run --default-repo=gcr.io/nimjay-microservices-demo
  • skaffold run --default-repo=gcr.io/nimjay-microservices-demo --module=app
  • skaffold run --default-repo=gcr.io/nimjay-microservices-demo --module=loadgenerator

Failing Check ⚠️
A pull-request Check is currently failing because I have yet to upgrade the version of skaffold on our virtual machines (similar to Bank of Anthos).

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 7, 2021
@NimJay
Copy link
Collaborator Author

NimJay commented Oct 7, 2021

Hi @gsquared94,
I am not able to assign you as a reviewer.
But a quick review from you would be extremely useful! :)
Let me know if you'd like me to change anything.

Copy link

@gsquared94 gsquared94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@askmeegs askmeegs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgraded GitHub actions runners from skaffold 1.21 to skaffold latest (1.33).

@github-actions
Copy link

🚲 PR staged at http://34.138.23.95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skaffold multi-config (or modules)
3 participants