Modified docs/development-guide.md to Reorganize prerequisites, add kubectl link, clone repo and accessing frontend #1853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Reordered prerequisites for better clarity and indicated items exclusive to either Option 1 or Option 2. 2. Added a link to kubectl in the prerequisites. 3. Added instructions to clone the repository. 4. Added a step in Option 1 to access the web frontend via http://EXTERNAL-IP.
NimJay
requested changes
Jun 20, 2023
Co-authored-by: Nim Jayawardena <[email protected]>
Co-authored-by: Nim Jayawardena <[email protected]>
Co-authored-by: Nim Jayawardena <[email protected]>
1. Remove `Enable GCP APIs for Cloud Monitoring, Tracing, Profiler` 2. Restore `Docker for Desktop` position and remove (for Option 2) 3. Change `Option1` to `Option 1` by following `Option 2`
|
Hi @NimJay Thank you for the review. The details of the changes are as follows.
Thank you. |
|
Hi @NimJay Although I don't anticipate any issues, I would appreciate if you could confirm this as well. |
NimJay
approved these changes
Jun 21, 2023
There was a problem hiding this comment.
Thank you for this contribution, @taka2noda. :)
And for addressing all my comments.
Ah, yes, the CLA was failing on my personal email address. I forced it to pass.
Approved. Merging.
mrcrgl
pushed a commit
to fiberfjord/microservices-demo
that referenced
this pull request
Sep 11, 2023
…ubectl link, clone repo and accessing frontend (GoogleCloudPlatform#1853) * Modified docs/development-guide.md 1. Reordered prerequisites for better clarity and indicated items exclusive to either Option 1 or Option 2. 2. Added a link to kubectl in the prerequisites. 3. Added instructions to clone the repository. 4. Added a step in Option 1 to access the web frontend via http://EXTERNAL-IP. * Update docs/development-guide.md Co-authored-by: Nim Jayawardena <[email protected]> * Update docs/development-guide.md Co-authored-by: Nim Jayawardena <[email protected]> * Update docs/development-guide.md Co-authored-by: Nim Jayawardena <[email protected]> * Update reffering to the review. 1. Remove `Enable GCP APIs for Cloud Monitoring, Tracing, Profiler` 2. Restore `Docker for Desktop` position and remove (for Option 2) 3. Change `Option1` to `Option 1` by following `Option 2` * Change Option1 to Option 1 at line8 kubectl... --------- Co-authored-by: Nim Jayawardena <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Fixes
Change Summary
Additional Notes
Testing Procedure
Related PRs or Issues