Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sending empty oauth2ClientId and oauth2ClientSecret string for null IAP message in google_compute_region_backend_service #9851

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Remove sending empty oauth2ClientId and oauth2ClientSecret string for null IAP message in google_compute_region_backend_service #9851

merged 2 commits into from
Jan 22, 2024

Conversation

arnabadg-google
Copy link
Contributor

@arnabadg-google arnabadg-google commented Jan 22, 2024 •
edited
Loading

Fixes internal issue b/319412975

Release Note Template for Downstream PRs (will be copied)

compute: remove sending empty oauth2ClientId and oauth2ClientSecret string for null IAP message in google_compute_region_backend_service as it triggers resource validation

@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 60 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 3 files changed, 60 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 2 deletions(-))
TF OiCS: Diff ( 4 files changed, 111 insertions(+))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 118 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 6 files changed, 118 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 2 files changed, 4 deletions(-))
TF OiCS: Diff ( 8 files changed, 221 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 866
Passed tests 643
Skipped tests: 64
Affected tests: 159

Click here to see the affected service packages
  • compute

Action taken

Found 159 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeBackendService_withBackendAndMaxUtilization|TestAccComputeBackendService_withBackendAndIAP|TestAccComputeRegionBackendService_withBackendAndIAP|TestAccComputeTargetSslProxy_update|TestAccComputeRegionUrlMap_ilbRouteUpdate|TestAccComputeRegionUrlMap_ilbPathUpdate|TestAccComputeRoute_routeIlbVipExample|TestAccComputeRoute_routeIlbExample|TestAccComputeRegionUrlMap_defaultRouteAction_full_update|TestAccComputeRegionUrlMap_noPathRulesWithUpdate|TestAccComputeRegionTargetTcpProxy_update|TestAccComputeRegionUrlMap_advanced|TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample|TestAccComputeForwardingRule_forwardingRuleExternallbExample|TestAccComputeRegionUrlMap_update_path_matcher|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample|TestAccComputeRegionUrlMap_regionUrlMapL7IlbRoutePartialExample|TestAccComputeRegionTargetTcpProxy_regionTargetTcpProxyBasicExample|TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample|TestAccComputeRegionUrlMap_regionUrlMapL7IlbRouteExample|TestAccComputeRegionTargetHttpsProxy_update|TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathPartialExample|TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyBasicExample|TestAccComputeRegionTargetHttpProxy_update|TestAccComputeRegionBackendService_regionBackendServiceExternalWeightedExample|TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathExample|TestAccComputeRegionUrlMap_regionUrlMapDefaultRouteActionExample|TestAccComputeRegionBackendService_ilbUpdateFull|TestAccComputeRegionBackendService_ilbUpdateBasic|TestAccComputeRegionBackendService_regionBackendServiceExternalExample|TestAccComputeRegionUrlMap_regionUrlMapBasicExample|TestAccComputeRegionBackendService_withSecurityPolicy|TestAccComputeRegionBackendService_regionBackendServiceIlbRoundRobinExample|TestAccComputeRegionBackendService_regionBackendServiceCacheExample|TestAccComputeRegionBackendService_regionBackendServiceExternalIapExample|TestAccComputeRegionTargetHttpProxy_regionTargetHttpProxyBasicExample|TestAccComputePacketMirroring_computePacketMirroringFullExample|TestAccComputeRegionBackendService_regionBackendServiceBasicExample|TestAccComputeRegionBackendService_withConnectionDrainingAndUpdate|TestAccComputeRegionBackendService_withBackendMultiNic|TestAccComputeRegionBackendService_withBackendInternalManaged|TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample|TestAccComputeRegionBackendService_subsettingUpdate|TestAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol|TestAccComputeRegionBackendService_basic|TestAccComputeRegionBackendService_withBackendInternal|TestAccComputeRegionBackendService_regionBackendServiceConnectionTrackingExample|TestAccComputeRegionBackendService_regionBackendServiceBalancingModeExample|TestAccComputeRegionBackendService_regionBackendServiceIlbRingHashExample|TestAccComputeRegionBackendService_UDPFailOverPolicyUpdate|TestAccComputeInstanceGroup_rename|TestAccComputeGlobalForwardingRule_labels|TestAccComputeGlobalForwardingRule_ipv6|TestAccComputeGlobalForwardingRule_globalForwardingRuleExternalManagedExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleHttpExample|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample|TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleHybridExample|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample|TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExampleUpdate|TestAccComputeGlobalForwardingRule_globalInternalHttpLbWithMigBackendExample|TestAccComputeForwardingRule_forwardingRulePscRecreate|TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample|TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate|TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate|TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample|TestAccComputeForwardingRule_forwardingRuleInternallbExample|TestAccComputeForwardingRule_forwardingRuleL3DefaultExample|TestAccComputeForwardingRule_forwardingRuleInternallbIpv6Example|TestAccComputeForwardingRule_forwardingRuleIpAddressIpv6|TestAccComputeForwardingRule_forwardingRuleVpcPscExample|TestAccComputeTargetHttpsProxy_targetHttpsProxyCertificateManagerCertificateExample|TestAccComputeBackendService_backendServiceCacheIncludeNamedCookiesExample|TestAccComputeForwardingRule_forwardingRuleHttpLbExample|TestAccComputeBackendService_backendServiceCacheExample|TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExample|TestAccComputeGlobalForwardingRule_updateTarget|TestAccComputeUrlMap_urlMapParameterBasedRoutingExample|TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample|TestAccComputeTargetTcpProxy_targetTcpProxyBasicExample|TestAccComputeUrlMap_urlMapHeaderBasedRoutingExample|TestAccComputeBackendService_backendServiceCacheIncludeHttpHeadersExample|TestAccComputeUrlMap_urlMapTrafficDirectorPathPartialExample|TestAccComputeUrlMap_update_path_matcher|TestAccComputeUrlMap_defaultRouteActionPathUrlRewrite|TestAccComputeUrlMap_urlMapPathTemplateMatchExample|TestAccComputeBackendService_backendServiceExternalIapExample|TestAccComputeUrlMap_defaultRouteActionUrlRewrite|TestAccComputeRegionBackendServiceIamPolicyGenerated|TestAccComputeUrlMap_defaultRouteActionTrafficDirectorUpdate|TestAccComputeUrlMap_trafficDirectorUpdate|TestAccComputeUrlMap_urlMapTrafficDirectorRouteExample|TestAccComputeUrlMap_advanced|TestAccComputeTargetSslProxy_targetSslProxyBasicExample|TestAccComputeUrlMap_defaultRouteActionTrafficDirectorPathUpdate|TestAccComputeUrlMap_noPathRulesWithUpdate|TestAccComputeBackendService_backendServiceCacheSimpleExample|TestAccComputeTargetTcpProxy_update|TestAccComputeUrlMap_urlMapTrafficDirectorRoutePartialExample|TestAccComputeTargetHttpsProxy_targetHttpsProxyMtlsExample|TestAccComputeTargetHttpsProxy_targetHttpsProxyHttpKeepAliveTimeoutExample|TestAccComputeBackendService_withCustomHeaders|TestAccComputeUrlMap_urlMapBucketAndServiceExample|TestAccComputeBackendService_backendServiceBasicExample|TestAccComputeBackendService_trafficDirectorUpdateLbPolicies|TestAccComputeUrlMap_urlMapTrafficDirectorPathExample|TestAccComputeBackendService_withCompressionMode|TestAccComputeBackendService_trafficDirectorUpdateFull|TestAccComputeUrlMap_trafficDirectorRemoveRouteRule|TestAccComputeRegionBackendServiceIamPolicyGenerated_withCondition|TestAccComputeBackendService_trafficDirectorUpdateBasic|TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate|TestAccComputeBackendService_withAffinityCookieTtlSec|TestAccComputeUrlMap_trafficDirectorPathUpdate|TestAccComputeTargetHttpsProxy_targetHttpsProxyBasicExample|TestAccComputeBackendService_withConnectionDrainingAndUpdate|TestAccComputeBackendService_withSecurityPolicy|TestAccComputeBackendService_withLogConfig|TestAccComputeServiceAttachment_serviceAttachmentReconcileConnectionsExample|TestAccComputeBackendService_withConnectionDraining|TestAccComputeTargetHttpProxy_update|TestAccComputeTargetHttpsProxy_update|TestAccComputeBackendService_withHttpsHealthCheck|TestAccComputeBackendService_withCdnPolicy|TestAccComputeBackendServiceIamPolicyGenerated|TestAccComputeBackendServiceIamBindingGenerated_withCondition|TestAccComputeBackendService_updatePreservesOptionalParameters|TestAccComputeBackendService_withMaxRatePerEndpoint|TestAccComputeRegionBackendServiceIamBindingGenerated_withCondition|TestAccComputeRegionBackendServiceIamMemberGenerated_withCondition|TestAccComputeBackendService_withBackend|TestAccComputeBackendService_withMaxConnectionsPerInstance|TestAccComputeBackendService_withMaxConnections|TestAccComputeBackendService_basic|TestAccComputeTargetHttpProxy_targetHttpProxyHttpKeepAliveTimeoutExample|TestAccComputeBackendService_backendServiceNetworkEndpointExample|TestAccComputeTargetHttpsProxy_certificateMap|TestAccComputeBackendServiceSignedUrlKey_basic|TestAccComputeBackendService_regionNegBackend|TestAccComputeBackendServiceIamMemberGenerated|TestAccComputeBackendServiceIamBindingGenerated|TestAccComputeBackendService_withMaxConnectionsPerEndpoint|TestAccComputeBackendService_backendServiceExternalManagedExample|TestAccComputeTargetGrpcProxy_targetGrpcProxyBasicExample|TestAccComputeTargetHttpProxy_targetHttpProxyBasicExample|TestAccComputeBackendService_backendServiceTrafficDirectorRingHashExample|TestAccComputeRegionBackendServiceIamMemberGenerated|TestAccComputeBackendService_withCDNEnabled|TestAccComputeBackendService_withSessionAffinity|TestAccComputeRegionBackendServiceIamBindingGenerated|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccComputeBackendService_backendServiceTrafficDirectorRoundRobinExample|TestAccComputeBackendServiceIamMemberGenerated_withCondition|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccComputeBackendService_backendServiceCacheBypassCacheOnRequestHeadersExample|TestAccComputeTargetGrpcProxy_update|TestAccComputeBackendServiceIamPolicyGenerated_withCondition|TestAccDataSourceComputeBackendService_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeBackendService_withBackendAndMaxUtilization[Debug log]
TestAccComputeBackendService_withBackendAndIAP[Debug log]
TestAccComputeRegionBackendService_withBackendAndIAP[Debug log]
TestAccComputeTargetSslProxy_update[Debug log]
TestAccComputeRegionUrlMap_ilbRouteUpdate[Debug log]
TestAccComputeRegionUrlMap_ilbPathUpdate[Debug log]
TestAccComputeRoute_routeIlbVipExample[Debug log]
TestAccComputeRoute_routeIlbExample[Debug log]
TestAccComputeRegionUrlMap_defaultRouteAction_full_update[Debug log]
TestAccComputeRegionUrlMap_noPathRulesWithUpdate[Debug log]
TestAccComputeRegionTargetTcpProxy_update[Debug log]
TestAccComputeRegionUrlMap_advanced[Debug log]
TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleExternallbExample[Debug log]
TestAccComputeRegionUrlMap_update_path_matcher[Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapL7IlbRoutePartialExample[Debug log]
TestAccComputeRegionTargetTcpProxy_regionTargetTcpProxyBasicExample[Debug log]
TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapL7IlbRouteExample[Debug log]
TestAccComputeRegionTargetHttpsProxy_update[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathPartialExample[Debug log]
TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyBasicExample[Debug log]
TestAccComputeRegionTargetHttpProxy_update[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceExternalWeightedExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapDefaultRouteActionExample[Debug log]
TestAccComputeRegionBackendService_ilbUpdateFull[Debug log]
TestAccComputeRegionBackendService_ilbUpdateBasic[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceExternalExample[Debug log]
TestAccComputeRegionUrlMap_regionUrlMapBasicExample[Debug log]
TestAccComputeRegionBackendService_withSecurityPolicy[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceIlbRoundRobinExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceCacheExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceExternalIapExample[Debug log]
TestAccComputeRegionTargetHttpProxy_regionTargetHttpProxyBasicExample[Debug log]
TestAccComputePacketMirroring_computePacketMirroringFullExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceBasicExample[Debug log]
TestAccComputeRegionBackendService_withConnectionDrainingAndUpdate[Debug log]
TestAccComputeRegionBackendService_withBackendMultiNic[Debug log]
TestAccComputeRegionBackendService_withBackendInternalManaged[Debug log]
TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample[Debug log]
TestAccComputeRegionBackendService_subsettingUpdate[Debug log]
TestAccComputeRegionBackendService_ilbBasic_withUnspecifiedProtocol[Debug log]
TestAccComputeRegionBackendService_basic[Debug log]
TestAccComputeRegionBackendService_withBackendInternal[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceConnectionTrackingExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceBalancingModeExample[Debug log]
TestAccComputeRegionBackendService_regionBackendServiceIlbRingHashExample[Debug log]
TestAccComputeRegionBackendService_UDPFailOverPolicyUpdate[Debug log]
TestAccComputeInstanceGroup_rename[Debug log]
TestAccComputeGlobalForwardingRule_labels[Debug log]
TestAccComputeGlobalForwardingRule_ipv6[Debug log]
TestAccComputeGlobalForwardingRule_globalForwardingRuleExternalManagedExample[Debug log]
TestAccComputeGlobalForwardingRule_globalForwardingRuleHttpExample[Debug log]
TestAccComputeGlobalForwardingRule_internalLoadBalancing[Debug log]
TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample[Debug log]
TestAccComputeGlobalForwardingRule_externalHttpLbMigBackendCustomHeaderExample[Debug log]
TestAccComputeGlobalForwardingRule_globalForwardingRuleHybridExample[Debug log]
TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExampleUpdate[Debug log]
TestAccComputeGlobalForwardingRule_globalInternalHttpLbWithMigBackendExample[Debug log]
TestAccComputeForwardingRule_forwardingRulePscRecreate[Debug log]
TestAccComputeGlobalForwardingRule_externalTcpProxyLbMigBackendExample[Debug log]
TestAccComputeForwardingRule_internalTcpUdpLbWithMigBackendExampleUpdate[Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscExampleUpdate[Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalHttpXlbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleInternallbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleL3DefaultExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleInternallbIpv6Example[Debug log]
TestAccComputeForwardingRule_forwardingRuleIpAddressIpv6[Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscExample[Debug log]
TestAccComputeTargetHttpsProxy_targetHttpsProxyCertificateManagerCertificateExample[Debug log]
TestAccComputeBackendService_backendServiceCacheIncludeNamedCookiesExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleHttpLbExample[Debug log]
TestAccComputeBackendService_backendServiceCacheExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleRegionalSteeringExample[Debug log]
TestAccComputeGlobalForwardingRule_updateTarget[Debug log]
TestAccComputeUrlMap_urlMapParameterBasedRoutingExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleVpcPscNoAutomateDnsExample[Debug log]
TestAccComputeTargetTcpProxy_targetTcpProxyBasicExample[Debug log]
TestAccComputeUrlMap_urlMapHeaderBasedRoutingExample[Debug log]
TestAccComputeBackendService_backendServiceCacheIncludeHttpHeadersExample[Debug log]
TestAccComputeUrlMap_urlMapTrafficDirectorPathPartialExample[Debug log]
TestAccComputeUrlMap_update_path_matcher[Debug log]
TestAccComputeUrlMap_defaultRouteActionPathUrlRewrite[Debug log]
TestAccComputeUrlMap_urlMapPathTemplateMatchExample[Debug log]
TestAccComputeBackendService_backendServiceExternalIapExample[Debug log]
TestAccComputeUrlMap_defaultRouteActionUrlRewrite[Debug log]
TestAccComputeRegionBackendServiceIamPolicyGenerated[Debug log]
TestAccComputeUrlMap_defaultRouteActionTrafficDirectorUpdate[Debug log]
TestAccComputeUrlMap_trafficDirectorUpdate[Debug log]
TestAccComputeUrlMap_urlMapTrafficDirectorRouteExample[Debug log]
TestAccComputeUrlMap_advanced[Debug log]
TestAccComputeTargetSslProxy_targetSslProxyBasicExample[Debug log]
TestAccComputeUrlMap_defaultRouteActionTrafficDirectorPathUpdate[Debug log]
TestAccComputeUrlMap_noPathRulesWithUpdate[Debug log]
TestAccComputeBackendService_backendServiceCacheSimpleExample[Debug log]
TestAccComputeTargetTcpProxy_update[Debug log]
TestAccComputeUrlMap_urlMapTrafficDirectorRoutePartialExample[Debug log]
TestAccComputeTargetHttpsProxy_targetHttpsProxyMtlsExample[Debug log]
TestAccComputeTargetHttpsProxy_targetHttpsProxyHttpKeepAliveTimeoutExample[Debug log]
TestAccComputeBackendService_withCustomHeaders[Debug log]
TestAccComputeUrlMap_urlMapBucketAndServiceExample[Debug log]
TestAccComputeBackendService_backendServiceBasicExample[Debug log]
TestAccComputeBackendService_trafficDirectorUpdateLbPolicies[Debug log]
TestAccComputeUrlMap_urlMapTrafficDirectorPathExample[Debug log]
TestAccComputeBackendService_withCompressionMode[Debug log]
TestAccComputeBackendService_trafficDirectorUpdateFull[Debug log]
TestAccComputeUrlMap_trafficDirectorRemoveRouteRule[Debug log]
TestAccComputeRegionBackendServiceIamPolicyGenerated_withCondition[Debug log]
TestAccComputeBackendService_trafficDirectorUpdateBasic[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate[Debug log]
TestAccComputeBackendService_withAffinityCookieTtlSec[Debug log]
TestAccComputeUrlMap_trafficDirectorPathUpdate[Debug log]
TestAccComputeTargetHttpsProxy_targetHttpsProxyBasicExample[Debug log]
TestAccComputeBackendService_withConnectionDrainingAndUpdate[Debug log]
TestAccComputeBackendService_withSecurityPolicy[Debug log]
TestAccComputeBackendService_withLogConfig[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentReconcileConnectionsExample[Debug log]
TestAccComputeBackendService_withConnectionDraining[Debug log]
TestAccComputeTargetHttpProxy_update[Debug log]
TestAccComputeTargetHttpsProxy_update[Debug log]
TestAccComputeBackendService_withHttpsHealthCheck[Debug log]
TestAccComputeBackendService_withCdnPolicy[Debug log]
TestAccComputeBackendServiceIamPolicyGenerated[Debug log]
TestAccComputeBackendServiceIamBindingGenerated_withCondition[Debug log]
TestAccComputeBackendService_updatePreservesOptionalParameters[Debug log]
TestAccComputeBackendService_withMaxRatePerEndpoint[Debug log]
TestAccComputeRegionBackendServiceIamBindingGenerated_withCondition[Debug log]
TestAccComputeRegionBackendServiceIamMemberGenerated_withCondition[Debug log]
TestAccComputeBackendService_withBackend[Debug log]
TestAccComputeBackendService_withMaxConnectionsPerInstance[Debug log]
TestAccComputeBackendService_withMaxConnections[Debug log]
TestAccComputeBackendService_basic[Debug log]
TestAccComputeTargetHttpProxy_targetHttpProxyHttpKeepAliveTimeoutExample[Debug log]
TestAccComputeBackendService_backendServiceNetworkEndpointExample[Debug log]
TestAccComputeTargetHttpsProxy_certificateMap[Debug log]
TestAccComputeBackendServiceSignedUrlKey_basic[Debug log]
TestAccComputeBackendService_regionNegBackend[Debug log]
TestAccComputeBackendServiceIamMemberGenerated[Debug log]
TestAccComputeBackendServiceIamBindingGenerated[Debug log]
TestAccComputeBackendService_withMaxConnectionsPerEndpoint[Debug log]
TestAccComputeBackendService_backendServiceExternalManagedExample[Debug log]
TestAccComputeTargetGrpcProxy_targetGrpcProxyBasicExample[Debug log]
TestAccComputeTargetHttpProxy_targetHttpProxyBasicExample[Debug log]
TestAccComputeBackendService_backendServiceTrafficDirectorRingHashExample[Debug log]
TestAccComputeRegionBackendServiceIamMemberGenerated[Debug log]
TestAccComputeBackendService_withCDNEnabled[Debug log]
TestAccComputeBackendService_withSessionAffinity[Debug log]
TestAccComputeRegionBackendServiceIamBindingGenerated[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentBasicExample[Debug log]
TestAccComputeBackendService_backendServiceTrafficDirectorRoundRobinExample[Debug log]
TestAccComputeBackendServiceIamMemberGenerated_withCondition[Debug log]
TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample[Debug log]
TestAccComputeBackendService_backendServiceCacheBypassCacheOnRequestHeadersExample[Debug log]
TestAccComputeTargetGrpcProxy_update[Debug log]
TestAccComputeBackendServiceIamPolicyGenerated_withCondition[Debug log]
TestAccDataSourceComputeBackendService_basic[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@trodge trodge merged commit 682308d into GoogleCloudPlatform:main Jan 22, 2024
12 checks passed
@arnabadg-google arnabadg-google deleted the iap branch January 22, 2024 21:49
This was referenced Jan 22, 2024
Merged
Merged
Merged
Merged
arnabadg-google added a commit to arnabadg-google/mm-arnabadg that referenced this pull request Jan 22, 2024
@arnabadg-google
Remove sending empty oauth2ClientId and oauth2ClientSecret string for…
bbdc52e 
… null IAP message in google_compute_region_backend_service (GoogleCloudPlatform#9851)

* Remove default addition of oauth2ClientId and oauth2ClientSecret in google_compute_region_backend_service

* Remove default addition of oauth2ClientId and oauth2ClientSecret in google_compute_backend_service
tdbhacks pushed a commit to tdbhacks/magic-modules that referenced this pull request Feb 6, 2024
@arnabadg-google @tdbhacks
Remove sending empty oauth2ClientId and oauth2ClientSecret string for…
2833605 
… null IAP message in google_compute_region_backend_service (GoogleCloudPlatform#9851)

* Remove default addition of oauth2ClientId and oauth2ClientSecret in google_compute_region_backend_service

* Remove default addition of oauth2ClientId and oauth2ClientSecret in google_compute_backend_service
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
@arnabadg-google @balanaguharsha
Remove sending empty oauth2ClientId and oauth2ClientSecret string for…
2230be3 
… null IAP message in google_compute_region_backend_service (GoogleCloudPlatform#9851)

* Remove default addition of oauth2ClientId and oauth2ClientSecret in google_compute_region_backend_service

* Remove default addition of oauth2ClientId and oauth2ClientSecret in google_compute_backend_service
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
@arnabadg-google @pengq-google
Remove sending empty oauth2ClientId and oauth2ClientSecret string for…
f75d986 
… null IAP message in google_compute_region_backend_service (GoogleCloudPlatform#9851)

* Remove default addition of oauth2ClientId and oauth2ClientSecret in google_compute_region_backend_service

* Remove default addition of oauth2ClientId and oauth2ClientSecret in google_compute_backend_service
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trodge trodge trodge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arnabadg-google @modular-magician @trodge