-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: permadiff issue when docker_repository
field is not specified
#9850
Conversation
relates to GoogleCloudPlatform/cloud-foundation-fabric#1987 When docker repository is not specified by default docker repository`projects/PROJECT_ID/locations/REGION/repositories/gcf-artifacts` is used.In such a case, terraform plan always generates a difference for `docker_repository`field as the module passes null value but the tfstate file has the above specifieddefault value. This fix allows one to prevent unnecessary infrastructure change.
Hello! I am a robot. It looks like you are a: Community Contributor @trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Tests analyticsTotal tests: Click here to see the affected service packages
|
…oogleCloudPlatform#9850) relates to GoogleCloudPlatform/cloud-foundation-fabric#1987 When docker repository is not specified by default docker repository`projects/PROJECT_ID/locations/REGION/repositories/gcf-artifacts` is used.In such a case, terraform plan always generates a difference for `docker_repository`field as the module passes null value but the tfstate file has the above specifieddefault value. This fix allows one to prevent unnecessary infrastructure change.
…oogleCloudPlatform#9850) relates to GoogleCloudPlatform/cloud-foundation-fabric#1987 When docker repository is not specified by default docker repository`projects/PROJECT_ID/locations/REGION/repositories/gcf-artifacts` is used.In such a case, terraform plan always generates a difference for `docker_repository`field as the module passes null value but the tfstate file has the above specifieddefault value. This fix allows one to prevent unnecessary infrastructure change.
…oogleCloudPlatform#9850) relates to GoogleCloudPlatform/cloud-foundation-fabric#1987 When docker repository is not specified by default docker repository`projects/PROJECT_ID/locations/REGION/repositories/gcf-artifacts` is used.In such a case, terraform plan always generates a difference for `docker_repository`field as the module passes null value but the tfstate file has the above specifieddefault value. This fix allows one to prevent unnecessary infrastructure change.
When docker repository is not specified, by default docker repository
projects/PROJECT_ID/locations/REGION/repositories/gcf-artifacts
is used. Refer https://cloud.google.com/functions/docs/reference/rest/v2beta/projects.locations.functions#dockerregistryIn such a case, terraform plan always generates a difference for
docker_repository
field.This fix prevents unnecessary infrastructure change by setting the default repository id received from API.
Relates to GoogleCloudPlatform/cloud-foundation-fabric#1987
Release Note Template for Downstream PRs (will be copied)