Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate generate downstream to go #9747

Merged
merged 4 commits into from
Jan 17, 2024
Merged

Migrate generate downstream to go #9747

merged 4 commits into from
Jan 17, 2024

Conversation

trodge
Copy link
Contributor

@trodge trodge commented Jan 3, 2024

Release Note Template for Downstream PRs (will be copied)

@trodge trodge force-pushed the magician-generate-downstreams branch 2 times, most recently from 618e3cf to b6353a9 Compare January 3, 2024 23:04
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@trodge trodge force-pushed the magician-generate-downstreams branch 2 times, most recently from 369ef99 to c7b27c5 Compare January 5, 2024 21:37
@trodge trodge marked this pull request as ready for review January 5, 2024 21:37
@trodge trodge requested a review from ScottSuarez January 5, 2024 21:38
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

ScottSuarez
ScottSuarez requested changes Jan 10, 2024
View reviewed changes
.ci/magician/cmd/generate_downstream.go Outdated Show resolved Hide resolved
.ci/magician/cmd/generate_downstream.go Outdated Show resolved Hide resolved
.ci/magician/cmd/generate_downstream.go Outdated Show resolved Hide resolved
.ci/magician/cmd/generate_downstream.go Outdated Show resolved Hide resolved
.ci/magician/cmd/generate_downstream.go Show resolved Hide resolved
@trodge trodge force-pushed the magician-generate-downstreams branch 3 times, most recently from ab1d028 to 66091fb Compare January 10, 2024 23:07
@trodge trodge requested a review from ScottSuarez January 10, 2024 23:08
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@trodge trodge force-pushed the magician-generate-downstreams branch from 66091fb to 1f3305d Compare January 10, 2024 23:52
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@trodge
Copy link
Contributor Author

trodge commented Jan 11, 2024

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@trodge trodge merged commit dab48df into GoogleCloudPlatform:main Jan 17, 2024
12 checks passed
@trodge trodge deleted the magician-generate-downstreams branch January 17, 2024 21:53
kylase pushed a commit to yuanchuankee/magic-modules that referenced this pull request Jan 21, 2024
@trodge
Migrate generate downstream to go (GoogleCloudPlatform#9747)
d44a1a7 
* Migrate generate downstream to go

* Push to scratch path even if nothing to commit

* Apply suggestions from code review

* Fix for new RequestCall method
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
@trodge @balanaguharsha
Migrate generate downstream to go (GoogleCloudPlatform#9747)
db60ee5 
* Migrate generate downstream to go

* Push to scratch path even if nothing to commit

* Apply suggestions from code review

* Fix for new RequestCall method
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
@trodge @pengq-google
Migrate generate downstream to go (GoogleCloudPlatform#9747)
25df1dc 
* Migrate generate downstream to go

* Push to scratch path even if nothing to commit

* Apply suggestions from code review

* Fix for new RequestCall method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScottSuarez ScottSuarez ScottSuarez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trodge @modular-magician @ScottSuarez