Add policycontroller fields to fleet default configs for GKE Hub Feature resource #9426
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| func expand<%= prefix -%><%= titlelize_property(property) -%>(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (interface{}, error) { | ||
| if v == nil { | ||
| return nil, nil | ||
| } | ||
|
|
||
| m, ok := v.([]interface{}) | ||
| if !ok { | ||
| return nil, fmt.Errorf("unable to convert %v to []interface{}", v) | ||
| } | ||
| req := make(map[string]interface{}) | ||
| for _, raw := range m { | ||
| if raw == nil { | ||
| continue | ||
| } | ||
|
|
||
| deploymentConfig := raw.(map[string]interface{}) | ||
| log.Printf("WTF*** config is: %v\n", deploymentConfig) | ||
|
There was a problem hiding this comment. Haha, just to make sure, is this abbrev. 'What the feature,' correct? |
||
| componentName := deploymentConfig["component"].(string) | ||
| delete(deploymentConfig, "component") | ||
|
|
||
| if v, ok := deploymentConfig["pod_toleration"]; ok { | ||
| deploymentConfig["pod_tolerations"] = v | ||
| delete(deploymentConfig, "pod_toleration") | ||
| } | ||
|
|
||
| if v, ok := deploymentConfig["pod_affinity"]; ok { | ||
| pa := v.(string) | ||
| if pa == "" { | ||
| delete(deploymentConfig, "pod_affinity") | ||
| } | ||
| } | ||
|
|
||
| if v, ok := deploymentConfig["replica_count"]; ok { | ||
| rc := v.(int) | ||
| if rc == 0 { | ||
| delete(deploymentConfig, "replica_count") | ||
| } | ||
| } | ||
|
|
||
| // Somehow the container_resources field gets encoded unexpectedly into an array. Fix that. | ||
| if v, ok := deploymentConfig["container_resources"]; ok { | ||
| if arr, ok := v.([]interface{}); ok && len(arr) == 1 { | ||
| actualCR := arr[0].(map[string]interface{}) | ||
| if l, ok := actualCR["limits"]; ok { | ||
| if lArr, ok := l.([]interface{}); ok && len(lArr) == 1 { | ||
| actualLimits := lArr[0].(map[string]interface{}) | ||
| actualCR["limits"] = actualLimits | ||
| } | ||
| } | ||
| if r, ok := actualCR["requests"]; ok { | ||
| if rArr, ok := r.([]interface{}); ok && len(rArr) == 1 { | ||
| actualRequests := rArr[0].(map[string]interface{}) | ||
| actualCR["requests"] = actualRequests | ||
| } | ||
| } | ||
| deploymentConfig["container_resources"] = actualCR | ||
| } else if ok && len(arr) == 0 { | ||
| delete(deploymentConfig, "container_resources") | ||
| } | ||
| } | ||
|
|
||
| req[componentName] = deploymentConfig | ||
| } | ||
|
|
||
| return req, nil | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| func expand<%= prefix -%><%= titlelize_property(property) -%>(v interface{}, d tpgresource.TerraformResourceData, config *transport_tpg.Config) (interface{}, error) { | ||
| if v == nil { | ||
| return nil, nil | ||
| } | ||
|
|
||
| m, ok := v.([]interface{}) | ||
| if !ok { | ||
| return nil, fmt.Errorf("unable to convert %v to []interface{}", v) | ||
| } | ||
| req := make(map[string]interface{}) | ||
| for _, raw := range m { | ||
| if raw == nil { | ||
| continue | ||
| } | ||
|
|
||
| bundleObj := raw.(map[string]interface{}) | ||
| bundleName := bundleObj["name"].(string) | ||
| delete(bundleObj, "name") | ||
| req[bundleName] = bundleObj | ||
| } | ||
|
|
||
| return req, nil | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| resource "google_gke_hub_feature" "feature" { | ||
| name = "policycontroller" | ||
| location = "global" | ||
| fleet_default_member_config { | ||
| policycontroller { | ||
| policy_controller_hub_config { | ||
| install_spec = "INSTALL_SPEC_ENABLED" | ||
| exemptable_namespaces = ["foo"] | ||
| policy_content { | ||
| bundle { | ||
| name = "policy-essentials-v2022" | ||
| exempted_namespaces = ["foo", "bar"] | ||
| } | ||
| template_library { | ||
| installation = "ALL" | ||
| } | ||
| } | ||
| audit_interval_seconds = 30 | ||
| referential_rules_enabled = true | ||
| } | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tonyzhc Hi, what's the main reason for skipping these? Were you able to test locally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test and the API dependencies don't work well with VCR tests. We instead covered them in the custom acceptance tests and added the skip VCR options. I have added more examples to serve the documentation purpose.