Revert "Add Update Connector Support for VPC Access Connectors (#8205)"

[hao-nan-li]

Reverts #8205

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
• Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

vpcaccess: reverted new behaviour introduced by resource `google_vpc_access_connector` in `4.75.0`. `min_throughput` and `max_throughput` fields lost their default value, and customers could not make deployment due to that change.

vpcaccess: reverted the ability to update the number of instances for resource `google_vpc_access_connector`

[rileykarson]

Can you write the release notes? We should address the bug, as well as note that the ability to update the number of instances has been removed.

[hao-nan-li]

Can you write the release notes? We should address the bug, as well as note that the ability to update the number of instances has been removed.

updated

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field max_throughput default value changed from to 300 on google_vpc_access_connector - reference
• Field max_throughput transitioned from optional+computed to optional google_vpc_access_connector - reference
• Field min_throughput default value changed from to 200 on google_vpc_access_connector - reference
• Field min_throughput transitioned from optional+computed to optional google_vpc_access_connector - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 7 files changed, 11 insertions(+), 194 deletions(-))
Terraform Beta: Diff ( 7 files changed, 11 insertions(+), 194 deletions(-))
TF Conversion: Diff ( 4 files changed, 7 insertions(+), 15 deletions(-))
TF OiCS: Diff ( 2 files changed, 1 insertion(+), 5 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2883
Passed tests 2571
Skipped tests: 301
Affected tests: 11

Action taken

Found 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccVPCAccessConnector_vpcAccessConnectorThroughput|TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccCloudFunctionsFunction_vpcConnector|TestAccCloudRunV2Job_cloudrunv2JobVpcaccessExample|TestAccCloudRunV2Service_cloudrunv2ServiceFullUpdate|TestAccCloudRunV2Service_cloudrunv2ServiceVpcaccessExample|TestAccCloudRunV2Job_cloudrunv2JobFullUpdate|TestAccAppEngineStandardAppVersion_update|TestAccVPCAccessConnector_vpcAccessConnectorSharedVpcExample|TestAccVPCAccessConnectorDatasource_basic|TestAccVPCAccessConnector_vpcAccessConnectorExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccVPCAccessConnector_vpcAccessConnectorThroughput[Debug log]
TestAccCloudFunctionsFunction_vpcConnector[Debug log]
TestAccCloudRunV2Job_cloudrunv2JobVpcaccessExample[Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceFullUpdate[Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceVpcaccessExample[Debug log]
TestAccCloudRunV2Job_cloudrunv2JobFullUpdate[Debug log]
TestAccAppEngineStandardAppVersion_update[Debug log]
TestAccVPCAccessConnector_vpcAccessConnectorSharedVpcExample[Debug log]
TestAccVPCAccessConnectorDatasource_basic[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]
TestAccVPCAccessConnector_vpcAccessConnectorExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[hao-nan-li]

Beta Run vpc.log

GA run
vpc.log