-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add remaining fields within deidentify_config.record_transformations.field_transformations
field of google_data_loss_prevention_deidentify_template
resource
#6886
Conversation
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 9052 insertions(+), 940 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccLoggingBucketConfigProject_cmekSettings|TestAccDataLossPreventionDeidentifyTemplate_dlpDeidentifyTemplate_recordTransformations_redactConfig_Update|TestAccDataLossPreventionDeidentifyTemplate_dlpDeidentifyTemplate_recordTransformations_replaceConfig_Update|TestAccDataLossPreventionDeidentifyTemplate_dlpDeidentifyTemplate_infoTypeTransformationsUpdate|TestAccDataLossPreventionDeidentifyTemplate_dlpDeidentifyTemplate_recordTransformations_cryptoReplaceFfxFpeConfig_Update|TestAccDataLossPreventionDeidentifyTemplate_dlpDeidentifyTemplate_recordTransformations_characterMaskConfig_Update|TestAccCloudFunctions2Function_fullUpdate|TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample|TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample|TestAccDataSourceGoogleServiceAccountIdToken_basic |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
6b63666
to
b1fbc79
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 8741 insertions(+), 940 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccLoggingBucketConfigProject_cmekSettings|TestAccDataLossPreventionDeidentifyTemplate_dlpDeidentifyTemplate_recordTransformationsUpdate|TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample|TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample|TestAccCloudFunctions2Function_fullUpdate |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
b1fbc79
to
90bba68
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 8793 insertions(+), 972 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccFirebaserulesRelease_BasicRelease|TestAccDataLossPreventionDeidentifyTemplate_dlpDeidentifyTemplate_recordTransformationsUpdate|TestAccContainerCluster_withInvalidGatewayApiConfigChannel|TestAccComputeRouterNat_withNatRules|TestAccComputeRouterNat_withPortAllocationMethods|TestAccComputeRouterNat_withNatIpsAndDrainNatIps|TestAccComputeRouterNat_removeLogConfig|TestAccComputeRouterNat_update|TestAccLoggingBucketConfigProject_cmekSettings |
Tests passed during RECORDING mode: All tests passed |
This can be used on data of type: double, long. | ||
|
||
If the bound Value type differs from the type of data being transformed, we will first attempt converting the type of the data to be transformed to match the type of the bound before comparing. | ||
|
||
See https://cloud.google.com/dlp/docs/concepts-bucketing to learn more. | ||
properties: | ||
- !ruby/object:Api::Type::NestedObject | ||
name: lowerBound | ||
description: | | ||
Lower bound value of buckets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This type of transformation is specific to numeric data:
This can be used on data of type: double, long.
But, the description shows there's some kind of type conversion that occurs:
If the bound Value type differs from the type of data being transformed, we will first attempt converting the type of the data to be transformed to match the type of the bound before comparing.
Because of this complexity I think we should leave all the different data types present here (see Value entity in API docs)
Properties are copy pasted from other instance of `Values` type field - https://cloud.google.com/dlp/docs/reference/rest/v2/Value
Properties are copy pasted from other instance of `Values` type field - https://cloud.google.com/dlp/docs/reference/rest/v2/Value
Empty object with no properties - similar to redactConfig
cryptoKey field copy/pasted from elsewhere in the yaml, as it uses the reused CryptoKey object (https://cloud.google.com/dlp/docs/reference/rest/v2/projects.deidentifyTemplates#DeidentifyTemplate.CryptoKey)
Some fields copy/pasted from elsewhere in the yaml, as they use reused objects
13696f0
to
5116d36
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 7921 insertions(+), 2184 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccLoggingBucketConfigProject_cmekSettings|TestAccDataLossPreventionDeidentifyTemplate_dlpDeidentifyTemplate_recordTransformationsUpdate|TestAccContainerCluster_withInvalidGatewayApiConfigChannel |
Tests passed during RECORDING mode: All tests passed |
just checking in to let you know I haven't forgotten this. Hoping to get to it this week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, a few questions re: docs & bootstrapping cryptokeys
mmv1/third_party/terraform/tests/resource_data_loss_prevention_deidentify_template_test.go
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/tests/resource_data_loss_prevention_deidentify_template_test.go
Outdated
Show resolved
Hide resolved
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 8351 insertions(+), 2652 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccFirebaserulesRelease_BasicRelease|TestAccLoggingBucketConfigProject_cmekSettings|TestAccDataLossPreventionDeidentifyTemplate_dlpDeidentifyTemplate_recordTransformationsUpdate|TestAccDataLossPreventionDeidentifyTemplate_dlpDeidentifyTemplate_infoTypeTransformationsUpdate|TestAccRegionInstanceGroupManager_stateful |
Tests passed during RECORDING mode: All tests passed |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 8485 insertions(+), 2658 deletions(-)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks! I'll wait for the tests to complete and then merge if it's all ok |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccDataLossPreventionDeidentifyTemplate_dlpDeidentifyTemplate_recordTransformationsUpdate|TestAccDataLossPreventionDeidentifyTemplate_dlpDeidentifyTemplate_infoTypeTransformationsUpdate |
Tests passed during RECORDING mode: All tests passed |
Part of hashicorp/terraform-provider-google#9836
This PR updates the
google_data_loss_prevention_deidentify_template
resource by adding multiple fields related to data transformations, underneath this parent field (deidentify_template.record_transformations.field_transformations.primitive_transformation
- link to API docs)These subfields are added:
crypto_replace_ffx_fpe_config
fixed_size_bucketing_config
bucketing_config
replace_with_info_type_config
time_part_config
crypto_hash_config
date_shift_config
crypto_deterministic_config
replace_dictionary_config
It does not include
replace_with_info_type_config
because this results in an error that the documentation doesn't hint at:If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)