Add mutex to google_tags_tag_binding

[ScottSuarez]

closes: hashicorp/terraform-provider-google#11381

Release Note Template for Downstream PRs (will be copied)

tags: fixed issue where tags could not be applied sequentially to the same parent in `google_tags_tag_binding`

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 14 insertions(+))
Terraform Beta: Diff ( 1 file changed, 14 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[rileykarson]

Drive-by comment: Is this mutex on the right parent? The error message suggests we need it on the resource, not the tag value: Error: Error creating TagBinding: googleapi: Error 400: Resource '//cloudresourcemanager.googleapis.com/projects/XXXXXX' has another tag binding operation in progress. with google_tags_tag_binding.bindings["fooo"],

[melinath]

lgtm assuming tests pass and this should share with tagvalue

double-checking this first

[melinath]

Okay, tags are a little weird because the resources each have a parent key and it means a different thing for each one. For tagKey parent is the organization; for tagValue the parent is a tagKey; for tagBinding the parent is the resource the tag value is being applied to. So tagBinding and tagValue would never overlap in terms of their mutex.

[ScottSuarez]

Drive-by comment: Is this mutex on the right parent? The error message suggests we need it on the resource, not the tag value: Error: Error creating TagBinding: googleapi: Error 400: Resource '//cloudresourcemanager.googleapis.com/projects/XXXXXX' has another tag binding operation in progress. with google_tags_tag_binding.bindings["fooo"],

Should be the correct resource. This is done on the resource through the parent link supplied. Stopping sequential bindings on eq parent links should solve the issue afaik

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 14 insertions(+))
Terraform Beta: Diff ( 1 file changed, 14 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[rileykarson]

Should be the correct resource. This is done on the resource through the parent link supplied. Stopping sequential bindings on eq parent links should solve the issue afaik

Ah, I thought parent referred to the TagValue for some reason and not the linked resource. Should have double-checked. Thanks!

[melinath]

lgtm

[modular-magician]

Tests count:
Total tests: 1965
Passed tests 1726
Skipped tests: 237
Failed tests: 2

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccAccessContextManager|TestAccContainerCluster_withAuthenticatorGroupsConfig

[modular-magician]

Tests failed during RECORDING mode:
TestAccAccessContextManager
TestAccContainerCluster_withAuthenticatorGroupsConfig [view]

Please fix these to complete your PR
You can view the build log here: https://storage.cloud.google.com/vcr-test-logs/beta/refs/heads/auto-pr-5878/artifacts/d2b05730-7e81-4cc9-885f-d4f86402a17a/build-log/recording_test.log and the debug log for each test here: https://console.cloud.google.com/storage/browser/vcr-test-logs/beta/refs/heads/auto-pr-5878/artifacts/d2b05730-7e81-4cc9-885f-d4f86402a17a/recording

[ScottSuarez]

API team is working to add support for this, checking this code in while they work on it b/228352372