-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addlogging_config
and monitoring_config
to container cluster
#5217
Conversation
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccContainerCluster_withLoggingConfig You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=206589 |
Tests failed during RECORDING mode: TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate Please fix these to complete your PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi ! 👋🏻
looks mostly good, I think we just need to add these fields to the markdown :)
🤦♂️ whoops, added |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccOrgPolicyPolicy_EnforcePolicy|TestAccOrgPolicyPolicy_FolderPolicy|TestAccOrgPolicyPolicy_OrganizationPolicy|TestAccOrgPolicyPolicy_ProjectPolicy You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=206712 |
Fixes hashicorp/terraform-provider-google#6583
Fixes hashicorp/terraform-provider-google#9901
Release Note Template for Downstream PRs (will be copied)