Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addlogging_config and monitoring_config to container cluster #5217

Merged
merged 2 commits into from
Sep 21, 2021

Conversation

c2thorn
Copy link
Member

@c2thorn c2thorn commented Sep 20, 2021

Fixes hashicorp/terraform-provider-google#6583
Fixes hashicorp/terraform-provider-google#9901

Release Note Template for Downstream PRs (will be copied)

container: added support for `logging_config` and `monitoring_config` to google_container_cluster

@google-cla google-cla bot added the cla: yes label Sep 20, 2021
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 217 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 3 files changed, 217 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccContainerCluster_withLoggingConfig You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=206589

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode: TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate Please fix these to complete your PR

@c2thorn c2thorn requested a review from ScottSuarez September 20, 2021 19:51
Copy link
Contributor

@ScottSuarez ScottSuarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi ! 👋🏻

looks mostly good, I think we just need to add these fields to the markdown :)

@c2thorn
Copy link
Member Author

c2thorn commented Sep 21, 2021

looks mostly good, I think we just need to add these fields to the markdown :)

🤦‍♂️ whoops, added

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 233 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 6 files changed, 236 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccOrgPolicyPolicy_EnforcePolicy|TestAccOrgPolicyPolicy_FolderPolicy|TestAccOrgPolicyPolicy_OrganizationPolicy|TestAccOrgPolicyPolicy_ProjectPolicy You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=206712

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants