Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix api-gateway import tests #5104

Merged

Conversation

ScottSuarez
Copy link
Contributor

closes hashicorp/terraform-provider-google#9789
closes hashicorp/terraform-provider-google#9782
closes hashicorp/terraform-provider-google#9785

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

apigateway: fixed import functionality for all `apigateway` resources

@google-cla google-cla bot added the cla: yes label Aug 17, 2021
@ScottSuarez ScottSuarez requested review from a team and rileykarson and removed request for a team August 17, 2021 23:01
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 23 insertions(+), 23 deletions(-))
Terraform Beta: Diff ( 11 files changed, 38 insertions(+), 50 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccApiGatewayApiIamBindingGenerated|TestAccApiGatewayApiIamPolicyGenerated|TestAccApiGatewayApiIamMemberGenerated|TestAccApiGatewayGatewayIamPolicyGenerated|TestAccApiGatewayGatewayIamBindingGenerated|TestAccApiGatewayGatewayIamMemberGenerated|TestAccComposerEnvironment_update|TestAccComposerEnvironment_withSoftwareConfig You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=201693

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm- seems like this fixes the resource but breaks IAM.

@ScottSuarez ScottSuarez changed the title fix api-gateway tests fix api-gateway import tests Aug 19, 2021
@ScottSuarez
Copy link
Contributor Author

should be fixed now

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 17 insertions(+), 17 deletions(-))
Terraform Beta: Diff ( 9 files changed, 28 insertions(+), 40 deletions(-))

@modular-magician
Copy link
Collaborator

Error trying to cancel build ()

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComposerEnvironment_update|TestAccComposerEnvironment_withSoftwareConfig|TestAccPrivatecaCaPool_privatecaCapoolEmptyBaseline You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=202079

@ScottSuarez ScottSuarez merged commit 3832aab into GoogleCloudPlatform:master Aug 20, 2021
@ScottSuarez ScottSuarez deleted the fix-api-gateway-imports branch August 20, 2021 16:07
khajduczenia pushed a commit to khajduczenia/magic-modules that referenced this pull request Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants