-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for dns_config
to google_container_cluster
#4945
Add support for dns_config
to google_container_cluster
#4945
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @slevenick, please review this PR or find an appropriate assignee. |
@googlebot I signed it! |
/gcbrun |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccBigqueryDataTransferConfig|TestAccBigQueryDataTable_jsonEquivalency|TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccComputeInstance_updateRunning_desiredStatusNotSet_notAllowStoppingForUpdate|TestAccComputeInstance_updateRunning_desiredStatusRunning_notAllowStoppingForUpdate|TestAccContainerCluster_withDNSConfig|TestAccContainerNodePool_withGPU|TestAccDialogflowCXAgent_dialogflowcxAgentFullExample|TestAccDialogflowCXAgent_update|TestAccPrivatecaCaPool_privatecaCapoolUpdate|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthorityBasicExample|TestAccPrivatecaCertificate_privatecaCertificateConfigExample|TestAccPrivatecaCertificate_privatecaCertificateNoAuthorityExample You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=196973 |
Tests failed during RECORDING mode: TestAccPrivatecaCaPool_privatecaCapoolUpdate Please fix these to complete your PR |
Maybe TestAccPrivatecaCaPool_privatecaCapoolUpdate failure is unrelated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall seems good to me, just a note on marking the docs as beta-only
mmv1/third_party/terraform/website/docs/r/container_cluster.html.markdown
Outdated
Show resolved
Hide resolved
…ml.markdown beta description Co-authored-by: Sam Levenick <[email protected]>
Is there anything else I need ? |
/gcbrun |
/gcbrun CI image issues |
/gcbrun more CI issues |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=199973" |
1 similar comment
/gcbrun |
Error trying to cancel build () |
1 similar comment
Error trying to cancel build () |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccAssuredWorkloadsWorkload_BasicHandWrittenTestAccComputeRouterPeer_basic|TestAccComputeRouterPeer_advertiseModeTestAccContainerCluster_withDNSConfigTestAccEssentialContactsContact_essentialContactExample|TestAccEventarcTrigger_BasicHandWritten|TestAccFirestoreIndex_firestoreIndexBasicExample You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=201567 |
Can't merge yet? |
/gcbrun Sorry, missed the follow-up on this! |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceComputeNetworkEndpointGroup|TestAccComputeHealthCheckDatasource_basic|TestAccDataSourceComposerEnvironment_basic|TestAccDataSourceGoogleComputeDefaultServiceAccount_basic|TestAccDataSourceComputeAddress|TestAccDataSourceComputeBackendService_basic|TestAccDataSourceComputeBackendBucket_basic|TestAccDataSourceComputeImage|TestAccDataSourceComputeImageFilter|TestAccDataSourceGoogleForwardingRule|TestAccDataSourceComputeGlobalAddress|TestAccDataSourceComputeHaVpnGateway|TestAccDataSourceGoogleComputeInstanceGroup_basic|TestAccDataSourceGoogleComputeInstanceGroup_withNamedPort|TestAccDataSourceGoogleComputeInstanceGroup_fromIGM|TestAccInstanceTemplateDatasource_name|TestAccDataSourceComputeNodeTypes_basic|TestAccDataSourceComputeInstanceSerialPort_basic|TestAccComputeRegions_basic|TestAccDataSourceGoogleNetwork|TestAccInstanceTemplateDatasource_filter_mostRecent|TestAccDataSourceComputeInstance_basic|TestAccInstanceTemplateDatasource_filter|TestAccDataSourceComputeResourcePolicy|TestAccDataSourceComputeRegionSslCertificate|TestAccDataSourceComputeSslCertificate|TestAccComputeZones_basic|TestAccDataSourceComputeRouter|TestAccComputeZones_filter|TestAccDataSourceGoogleSubnetwork|TestAccDataSourceGoogleSslPolicy|TestAccDataSourceGoogleVpnGateway|TestAccContainerClusterDatasource_regional|TestAccContainerClusterDatasource_zonal|TestAccDataSourceGoogleGlobalForwardingRule|TestAccComputeDiskIamBindingGenerated|TestAccComputeDiskIamMemberGenerated|TestAccComputeImageIamBindingGenerated|TestAccComputeDiskIamPolicyGenerated|TestAccComputeImageIamMemberGenerated|TestAccComputeImageIamPolicyGenerated|TestAccComputeImageIamBindingGenerated_withCondition|TestAccComputeImageIamMemberGenerated_withCondition|TestAccComputeInstanceIamBindingGenerated|TestAccComputeImageIamPolicyGenerated_withCondition|TestAccComputeInstanceIamMemberGenerated|TestAccComputeInstanceIamBindingGenerated_withCondition|TestAccComputeInstanceIamMemberGenerated_withCondition|TestAccComputeInstanceIamPolicyGenerated|TestAccComputeMachineImageIamBindingGenerated|TestAccComputeMachineImageIamMemberGenerated|TestAccComputeInstanceIamPolicyGenerated_withCondition|TestAccComputeMachineImageIamBindingGenerated_withCondition|TestAccComputeMachineImageIamPolicyGenerated|TestAccComputeRegionDiskIamBindingGenerated|TestAccComputeMachineImageIamMemberGenerated_withCondition|TestAccComputeRegionDiskIamMemberGenerated|TestAccComputeMachineImageIamPolicyGenerated_withCondition|TestAccComputeSubnetworkIamBindingGenerated|TestAccComputeRegionDiskIamPolicyGenerated|TestAccComputeSubnetworkIamMemberGenerated|TestAccComputeSubnetworkIamBindingGenerated_withCondition|TestAccComputeSubnetworkIamMemberGenerated_withCondition|TestAccComputeSubnetworkIamPolicyGenerated_withCondition|TestAccComputeSubnetworkIamPolicyGenerated|TestAccIapTunnelInstanceIamBindingGenerated|TestAccIapTunnelInstanceIamMemberGenerated|TestAccIapTunnelInstanceIamBindingGenerated_withCondition|TestAccIapTunnelInstanceIamPolicyGenerated|TestAccIapTunnelInstanceIamMemberGenerated_withCondition|TestAccIapTunnelInstanceIamPolicyGenerated_withCondition|TestAccIapWebBackendServiceIamBindingGenerated|TestAccIapWebBackendServiceIamMemberGenerated|TestAccIapWebBackendServiceIamPolicyGenerated|TestAccIapWebBackendServiceIamBindingGenerated_withCondition|TestAccIapWebBackendServiceIamMemberGenerated_withCondition|TestAccIapWebBackendServiceIamPolicyGenerated_withCondition|TestAccProviderBasePath_setBasePath|TestAccProviderMeta_setModuleName|TestAccApiGatewayApi_apigatewayApiFullExample|TestAccApiGatewayApi_apigatewayApiBasicExample|TestAccApiGatewayGateway_apigatewayGatewayFullExample|TestAccArtifactRegistryRepository_artifactRegistryRepositoryBasicExample|TestAccAssuredWorkloadsWorkload_BasicHandWritten|TestAccArtifactRegistryRepository_artifactRegistryRepositoryCmekExample|TestAccAssuredWorkloadsWorkload_FullHandWritten|TestAccArtifactRegistryRepository_artifactRegistryRepositoryIamExample|TestAccCloudSchedulerJob_schedulerJobOauthExample|TestAccCloudSchedulerJob_schedulerJobOidcExample|TestAccCloudbuildWorkerPool_withNetwork|TestAccCloudFunctionsFunction_serviceAccountEmail|TestAccCloudFunctionsFunction_vpcConnector|TestAccComposerEnvironment_basic|TestAccComposerEnvironment_update|TestAccComposerEnvironment_privateWithWebServerControl|TestAccComposerEnvironment_private|TestAccComposerEnvironment_withDatabaseConfig|TestAccComposerEnvironment_withWebServerConfig|TestAccComposerEnvironment_withSoftwareConfig|TestAccComposerEnvironment_withUpdateOnCreate|TestAccComputeAddress_addressBasicExample|TestAccComposerEnvironment_withMaintenanceWindow|TestAccComputeAddress_instanceWithIpExample|TestAccComputeAddress_addressWithSubnetworkExample|TestAccComputeAddress_addressWithGceEndpointExample|TestAccComputeAddress_addressWithSharedLoadbalancerVipExample|TestAccComputeAddress_networkTier|TestAccComposerEnvironment_withEncryptionConfig|TestAccComputeAddress_computeAddressIpsecInterconnectExample|TestAccComputeAddress_internal|TestAccComposerEnvironment_withNodeConfig|TestAccComputeAutoscaler_autoscalerSingleInstanceExample|TestAccComputeAttachedDisk_full|TestAccComputeAttachedDisk_basic|TestAccComputeAttachedDisk_region|TestAccComputeAttachedDisk_count|TestAccComputeAutoscaler_autoscalerBasicExample|TestAccComputeAutoscaler_update|TestAccComputeAutoscaler_scaleDownControl|TestAccComputeAutoscaler_multicondition|TestAccComputeAutoscaler_scalingSchedule|TestAccComputeAutoscaler_scaleInControl|TestAccComputeAutoscaler_scaleInControlFixed|TestAccComputeBackendBucketSignedUrlKey_basic|TestAccComputeBackendBucket_backendBucketBasicExample|TestAccComputeBackendBucket_backendBucketFullExample|TestAccComputeBackendService_backendServiceCacheSimpleExample|TestAccComputeBackendService_backendServiceCacheExample|TestAccComputeBackendService_backendServiceBasicExample|TestAccComputeBackendService_backendServiceTrafficDirectorRoundRobinExample|TestAccComputeBackendBucket_basicModified|TestAccComputeBackendService_backendServiceTrafficDirectorRingHashExample|TestAccComputeBackendBucket_withCdnPolicy|TestAccComputeBackendService_withBackend|TestAccComputeBackendService_withBackendAndMaxUtilization|TestAccComputeBackendService_withBackendAndIAP|TestAccComputeBackendService_backendServiceNetworkEndpointExample|TestAccComputeBackendService_updatePreservesOptionalParameters|TestAccComputeBackendService_basic|TestAccComputeBackendServiceSignedUrlKey_basic|TestAccComputeBackendService_withConnectionDrainingAndUpdate|TestAccComputeBackendService_withConnectionDraining|TestAccComputeBackendService_withHttpsHealthCheck|TestAccComputeBackendService_withCdnPolicy|TestAccComputeBackendService_withMaxConnections|TestAccComputeBackendService_withMaxRatePerEndpoint|TestAccComputeBackendService_withMaxConnectionsPerInstance|TestAccComputeBackendService_withCDNEnabled|TestAccComputeBackendService_withSessionAffinity|TestAccComputeBackendService_withMaxConnectionsPerEndpoint|TestAccComputeBackendService_withSecurityPolicy|TestAccComputeBackendService_withAffinityCookieTtlSec|TestAccComputeDiskResourcePolicyAttachment_diskResourcePolicyAttachmentBasicExample|TestAccComputeBackendService_withCustomHeaders|TestAccComputeDiskResourcePolicyAttachment_update|TestAccComputeDisk_fromSnapshot|TestAccComputeBackendService_trafficDirectorUpdateBasic|TestAccComputeDisk_encryption|TestAccComputeBackendService_withLogConfig|TestAccComputeDisk_update|TestAccComputeDisk_diskBasicExample|TestAccComputeBackendService_trafficDirectorUpdateFull|TestAccComputeDisk_deleteDetach|TestAccComputeDisk_resourcePolicies|TestAccComputeDisk_encryptionKMS|TestAccComputeDisk_interface|TestAccComputeDisk_multiWriter|TestAccComputeFirewall_priority|TestAccComputeFirewall_firewallBasicExample|TestAccComputeFirewall_update|TestAccComputeFirewall_noSource|TestAccComputeForwardingRule_forwardingRuleExternallbExample|TestAccComputeFirewall_disabled|TestAccComputeFirewall_denied|TestAccComputeFirewall_enableLogging|TestAccComputeFirewall_egress|TestAccComputeForwardingRule_forwardingRuleHttpLbExample|TestAccComputeForwardingRule_forwardingRuleGlobalInternallbExample|TestAccComputeFirewall_serviceAccounts|TestAccComputeForwardingRule_forwardingRuleBasicExample|TestAccComputeBackendService_regionNegBackend|TestAccComputeForwardingRule_forwardingRuleInternallbExample|TestAccComputeGlobalForwardingRule_globalForwardingRuleInternalExample|TestAccComputeForwardingRule_update|TestAccComputeForwardingRule_ip|TestAccComputeForwardingRule_networkTier|TestAccComputeGlobalAddress_globalAddressBasicExample|TestAccComputeGlobalAddress_globalAddressPrivateServicesConnectExample|TestAccComputeGlobalAddress_ipv6|TestAccComputeGlobalAddress_internal|TestAccComputeGlobalForwardingRule_globalForwardingRuleHttpExample|TestAccComputeGlobalForwardingRule_privateServiceConnectGoogleApisExample|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccComputeGlobalForwardingRule_updateTarget|TestAccComputeGlobalForwardingRule_ipv6|TestAccComputeGlobalForwardingRule_labels|TestAccComputeGlobalNetworkEndpointGroup_globalNetworkEndpointGroupExample|TestAccComputeGlobalNetworkEndpoint_networkEndpointsBasic|TestAccComputeHaVpnGateway_haVpnGatewayBasicExample|TestAccComputeGlobalNetworkEndpointGroup_globalNetworkEndpointGroupIpAddressExample|TestAccComputeHealthCheck_healthCheckTcpExample|TestAccComputeHaVpnGateway_computeHaVpnGatewayEncryptedInterconnectExample|TestAccComputeHealthCheck_healthCheckTcpFullExample|TestAccComputeHealthCheck_healthCheckSslExample|TestAccComputeHealthCheck_healthCheckHttpExample|TestAccComputeHealthCheck_healthCheckSslFullExample|TestAccComputeHealthCheck_healthCheckHttpFullExample|TestAccComputeHealthCheck_healthCheckHttpsExample|TestAccComputeHealthCheck_healthCheckHttpsFullExample|TestAccComputeHealthCheck_healthCheckGrpcExample|TestAccComputeHealthCheck_healthCheckHttp2Example|TestAccComputeHealthCheck_healthCheckWithLoggingExample|TestAccComputeHealthCheck_healthCheckHttp2FullExample|TestAccComputeHealthCheck_healthCheckGrpcFullExample|TestAccComputeHealthCheck_tcp_update|TestAccComputeHealthCheck_ssl_port_spec|TestAccComputeHealthCheck_https_serving_port|TestAccComputeHealthCheck_http_port_spec|TestAccComputeHealthCheck_typeTransition|TestAccComputeHealthCheck_logConfigDisabled|TestAccComputeHttpHealthCheck_httpHealthCheckBasicExample|TestAccComputeImage_basedondisk|TestAccComputeHttpsHealthCheck_httpsHealthCheckBasicExample|TestAccComputeHttpsHealthCheck_update|TestAccComputeImage_withLicense|TestAccComputeImage_imageGuestOsExample|TestAccComputeHttpHealthCheck_update|TestAccComputeImage_imageBasicExample|TestAccComputeImage_resolveImage|TestAccComputeImage_sourceImage|TestAccComputeImage_sourceSnapshot|TestAccComputeImage_update|TestAccComputeInstanceFromTemplate_basic|TestAccComputeInstanceFromTemplate_overrideAttachedDisk|TestAccComputeInstanceFromTemplate_overrideBootDisk|TestAccComputeInstanceFromTemplate_overrideScratchDisk|TestAccComputeInstanceFromTemplate_overrideScheduling|TestAccComputeInstanceFromTemplate_012_removableFields|TestAccComputeInstanceFromMachineImage_basic|TestAccInstanceGroupManager_targetSizeZero|TestAccComputeInstanceFromTemplate_overrideMetadataDotStartupScript|TestAccInstanceGroupManager_basic|TestAccComputeInstanceFromMachineImage_overrideMetadataDotStartupScript|TestAccInstanceGroupManager_update|TestAccComputeInstanceGroup_basic|TestAccInstanceGroupManager_versions|TestAccInstanceGroupManager_autoHealingPolicies|TestAccComputeInstanceGroup_rename|TestAccInstanceGroupManager_stateful|TestAccInstanceGroupManager_waitForStatus|TestAccComputeInstanceGroup_update|TestAccComputeInstanceGroup_outOfOrderInstances|TestAccComputeInstanceGroup_network|TestAccComputeInstanceTemplate_networkIPAddress|TestAccComputeInstanceTemplate_IP|TestAccComputeInstanceTemplate_basic|TestAccComputeInstanceTemplate_networkIP|TestAccComputeInstanceTemplate_preemptible|TestAccComputeInstanceTemplate_networkTier|TestAccComputeInstanceTemplate_disks|TestAccComputeInstanceTemplate_subnet_auto|TestAccComputeInstanceTemplate_disksInvalid|TestAccComputeInstanceTemplate_regionDisks|TestAccComputeInstanceTemplate_imageShorthand|TestAccComputeInstanceIamPolicy|TestAccComputeInstanceTemplate_subnet_custom|TestAccComputeInstanceTemplate_secondaryAliasIpRange|TestAccComputeInstanceTemplate_guestAccelerator|TestAccComputeInstanceTemplate_guestAcceleratorSkip|TestAccComputeInstanceTemplate_metadata_startup_script|TestAccComputeInstanceTemplate_primaryAliasIpRange|TestAccComputeInstanceTemplate_minCpuPlatform|TestAccComputeInstanceTemplate_EncryptKMS|TestAccComputeInstanceTemplate_reservationAffinities|TestAccComputeInstanceTemplate_soleTenantNodeAffinities|TestAccComputeInstanceTemplate_shieldedVmConfig1|TestAccComputeInstanceTemplate_shieldedVmConfig2|TestAccComputeInstanceTemplate_enableDisplay|TestAccComputeInstanceTemplate_AdvancedMachineFeatures|TestAccComputeInstanceTemplate_ConfidentialInstanceConfigMain|TestAccComputeInstanceTemplate_withScratchDisk|TestAccComputeInstanceTemplate_resourcePolicies|TestAccComputeInstance_basic3|TestAccComputeInstance_basic1|TestAccComputeInstance_basic2|TestAccComputeInstance_basic5|TestAccComputeInstance_basic4|TestAccComputeInstanceTemplate_nictype_update|TestAccComputeInstance_IP|TestAccComputeInstance_networkTier|TestAccComputeInstance_diskEncryption|TestAccComputeInstance_diskEncryptionRestart|TestAccComputeInstance_PTRRecord|TestAccComputeInstance_attachedDisk_sourceUrl|TestAccComputeInstance_attachedDisk|TestAccComputeInstance_kmsDiskEncryption|TestAccComputeInstance_attachedDisk_modeRo|TestAccComputeInstance_attachedDiskUpdate|TestAccComputeInstance_bootDisk_source|TestAccComputeInstance_bootDisk_sourceUrl|TestAccComputeInstance_bootDisk_type|TestAccComputeInstance_scratchDisk|TestAccComputeInstance_update|TestAccComputeInstance_bootDisk_mode|TestAccComputeInstance_forceNewAndChangeMetadata|TestAccComputeInstance_stopInstanceToUpdate|TestAccComputeInstance_serviceAccount_updated|TestAccComputeInstance_serviceAccount|TestAccComputeInstance_advancedMachineFeatures|TestAccComputeInstance_serviceAccount_updated0to1to0scopes|TestAccComputeInstance_scheduling|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeInstance_reservationAffinities|TestAccComputeInstance_networkIPAuto|TestAccComputeInstance_subnet_auto|TestAccComputeInstance_subnet_custom|TestAccComputeInstance_network_ip_custom|TestAccComputeInstance_private_image_family|TestAccComputeInstance_forceChangeMachineTypeManually|TestAccComputeInstance_networkPerformanceConfig|TestAccComputeInstance_multiNic|TestAccComputeInstance_guestAcceleratorSkip|TestAccComputeInstance_guestAccelerator|TestAccComputeInstance_minCpuPlatform|TestAccComputeInstance_deletionProtectionExplicitTrueAndUpdateFalse|TestAccComputeInstance_deletionProtectionExplicitFalse|TestAccComputeInstance_primaryAliasIpRange|TestAccComputeInstance_secondaryAliasIpRange|TestAccComputeInstance_hostname|TestAccComputeInstance_shieldedVmConfig|TestAccComputeInstanceConfidentialInstanceConfigMain|TestAccComputeInstance_nictype_update|TestAccComputeInstance_enableDisplay|TestAccComputeInstance_desiredStatusTerminatedUpdateFields|TestAccComputeInstance_desiredStatusOnCreation|TestAccComputeInstance_desiredStatusUpdateBasic|TestAccComputeInstance_updateRunning_desiredStatusRunning_allowStoppingForUpdate|TestAccComputeInstance_updateRunning_desiredStatusNotSet_notAllowStoppingForUpdate|TestAccComputeInstance_updateRunning_desiredStatusRunning_notAllowStoppingForUpdate|TestAccComputeInstance_updateRunning_desiredStatusTerminated_allowStoppingForUpdate|TestAccComputeInstance_updateTerminated_desiredStatusNotSet_allowStoppingForUpdate|TestAccComputeInstance_updateRunning_desiredStatusTerminated_notAllowStoppingForUpdate|TestAccComputeInstance_updateTerminated_desiredStatusTerminated_allowStoppingForUpdate|TestAccComputeInstance_updateTerminated_desiredStatusTerminated_notAllowStoppingForUpdate|TestAccComputeInstance_updateTerminated_desiredStatusNotSet_notAllowStoppingForUpdate|TestAccComputeInstance_updateTerminated_desiredStatusRunning_allowStoppingForUpdate|TestAccComputeInstance_updateTerminated_desiredStatusRunning_notAllowStoppingForUpdate|TestAccComputeInstance_resourcePolicyCollocate|TestAccComputeInstance_subnetworkUpdate|TestAccComputeMachineImage_machineImageBasicExample|TestAccComputeInterconnectAttachment_computeInterconnectAttachmentIpsecEncryptionExample|TestAccComputeInterconnectAttachment_interconnectAttachmentBasicExample|TestAccComputeNetworkEndpointGroup_networkEndpointGroupExample|TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample|TestAccComputeNetwork_networkCustomMtuExample|TestAccComputeNetwork_networkBasicExample|TestAccComputeNetworkPeering_basic|TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigBasicExample|TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigGkeExample|TestAccComputeNetworkPeering_subnetRoutes|TestAccComputeNetworkPeering_customRoutesUpdate|TestAccComputeNetwork_customSubnet|TestAccComputeNetwork_explicitAutoSubnet|TestAccComputeNodeTemplate_nodeTemplateServerBindingExample|TestAccComputeMachineImage_computeMachineImageKmsExample|TestAccComputeNetwork_networkDeleteDefaultRoute|TestAccComputeNetwork_routingModeAndUpdate|TestAccComputeNetwork_default_routing_mode|TestAccComputeNodeGroup_nodeGroupBasicExample|TestAccComputeNodeGroup_nodeGroupAutoscalingPolicyExample|TestAccComputeNodeTemplate_nodeTemplateBasicExample|TestAccComputeNodeGroup_updateNodeTemplate|TestAccComputeOrganizationSecurityPolicyAssociation_organizationSecurityPolicyAssociationBasicExample|TestAccComputePerInstanceConfig_update|TestAccComputeOrganizationSecurityPolicy_organizationSecurityPolicyBasicExample|TestAccComputeOrganizationSecurityPolicyRule_organizationSecurityPolicyRuleBasicExample|TestAccComputeOrganizationSecurityPolicyRule_organizationSecurityPolicyRuleUpdateExample|TestAccComputeOrganizationSecurityPolicy_organizationSecurityPolicyUpdateExample|TestAccComputePacketMirroring_computePacketMirroringFullExample|TestAccComputeProjectMetadataItem_basic|TestAccComputeProjectMetadataItem_basicUpdate|TestAccComputeProjectMetadataItem_basicWithEmptyVal|TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample|TestAccComputeProjectMetadataItem_exists|TestAccComputeRegionAutoscaler_update|TestAccComputeRegionAutoscaler_scalingSchedule|TestAccComputeRegionAutoscaler_scaleDownControl|TestAccComputeRegionAutoscaler_scaleInControl|TestAccComputeRegionBackendService_regionBackendServiceBasicExample|TestAccComputeRegionBackendService_regionBackendServiceBalancingModeExample|TestAccComputeRegionBackendService_regionBackendServiceCacheExample|TestAccComputeRegionBackendService_regionBackendServiceIlbRoundRobinExample|TestAccComputeRegionBackendService_regionBackendServiceExternalExample|TestAccComputeRegionBackendService_regionBackendServiceIlbRingHashExample|TestAccComputeRegionBackendService_basic|TestAccComputeRegionBackendService_withBackendInternal|TestAccComputeRegionBackendService_withBackendInternalManaged|TestAccComputeRegionBackendService_withBackendMultiNic|TestAccComputeRegionDiskResourcePolicyAttachment_regionDiskResourcePolicyAttachmentBasicExample|TestAccComputeRegionBackendService_withConnectionDrainingAndUpdate|TestAccComputeRegionBackendService_ilbUpdateFull|TestAccComputeRegionBackendService_ilbUpdateBasic|TestAccComputeRegionDisk_regionDiskBasicExample|TestAccComputeProjectDefaultNetworkTier_basic|TestAccComputeProjectDefaultNetworkTier_modify|TestAccComputeRegionDisk_basic|TestAccComputeRegionDisk_basicUpdate|TestAccComputeProjectMetadata_basic|TestAccComputeRegionDisk_encryption|TestAccComputeRegionDisk_deleteDetach|TestAccComputeProjectMetadata_modify_2|TestAccComputeProjectMetadata_modify_1|TestAccComputeRegionHealthCheck_regionHealthCheckTcpExample|TestAccComputeRegionDisk_interface|TestAccComputeRegionHealthCheck_regionHealthCheckSslExample|TestAccComputeRegionHealthCheck_regionHealthCheckTcpFullExample|TestAccComputeRegionHealthCheck_regionHealthCheckHttpLogsExample|TestAccComputeRegionHealthCheck_regionHealthCheckSslFullExample|TestAccComputeRegionHealthCheck_regionHealthCheckHttpExample|TestAccComputeRegionHealthCheck_regionHealthCheckHttpsExample|TestAccComputeRegionHealthCheck_regionHealthCheckHttpFullExample|TestAccComputeRegionHealthCheck_regionHealthCheckHttp2Example|TestAccComputeRegionHealthCheck_regionHealthCheckHttpsFullExample|TestAccComputeRegionHealthCheck_regionHealthCheckGrpcExample|TestAccComputeRegionHealthCheck_regionHealthCheckHttp2FullExample|TestAccComputeRegionHealthCheck_regionHealthCheckGrpcFullExample|TestAccComputeRegionHealthCheck_tcp_update|TestAccComputeRegionHealthCheck_https_serving_port|TestAccComputeRegionHealthCheck_ssl_port_spec|TestAccComputeRegionHealthCheck_typeTransition|TestAccRegionInstanceGroupManager_targetSizeZero|TestAccRegionInstanceGroupManager_basic|TestAccComputeRegionHealthCheck_http_port_spec|TestAccRegionInstanceGroupManager_update|TestAccRegionInstanceGroupManager_versions|TestAccRegionInstanceGroupManager_autoHealingPolicies|TestAccRegionInstanceGroupManager_distributionPolicy|TestAccRegionInstanceGroupManager_stateful|TestAccComputeRegionPerInstanceConfig_update|TestAccComputeRegionTargetHttpsProxy_update|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupFunctionsExample|TestAccComputeRegionTargetHttpProxy_regionTargetHttpProxyBasicExample|TestAccComputeRegionTargetHttpProxy_regionTargetHttpProxyHttpsRedirectExample|TestAccComputeRegionTargetHttpsProxy_regionTargetHttpsProxyBasicExample|TestAccComputeRegionTargetHttpProxy_update|TestAccComputeRegionUrlMap_regionUrlMapBasicExample|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupAppengineExample|TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathExample|TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathPartialExample|TestAccComputeRegionUrlMap_regionUrlMapL7IlbRouteExample|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupCloudrunExample|TestAccComputeRegionUrlMap_regionUrlMapL7IlbRoutePartialExample|TestAccComputeRegionUrlMap_update_path_matcher|TestAccComputeRegionUrlMap_ilbRouteUpdate|TestAccComputeRegionUrlMap_ilbPathUpdate|TestAccComputeRegionUrlMap_advanced|TestAccComputeRegionUrlMap_defaultUrlRedirectWithinPathMatcher|TestAccComputeRegionUrlMap_noPathRulesWithUpdate|TestAccComputeReservation_reservationBasicExample|TestAccComputeRegionUrlMap_defaultUrlRedirect|TestAccComputeReservation_update|TestAccComputeResourcePolicy_resourcePolicyBasicExample|TestAccComputeResourcePolicy_attached|TestAccComputeRoute_hopInstance|TestAccComputeResourcePolicy_resourcePolicyFullExample|TestAccComputeResourcePolicy_resourcePolicyPlacementPolicyExample|TestAccComputeResourcePolicy_resourcePolicyInstanceSchedulePolicyExample|TestAccComputeRoute_routeIlbExample|TestAccComputeRoute_routeBasicExample|TestAccComputeRoute_defaultInternetGateway|TestAccComputeRouterPeer_advertiseMode|TestAccComputeRouterPeer_basic|TestAccComputeRouter_routerBasicExample|TestAccComputeRouter_computeRouterEncryptedInterconnectExample|TestAccComputeRouterInterface_basic|TestAccComputeRouterInterface_withTunnel|TestAccComputeRouterNat_update|TestAccComputeRouterNat_basic|TestAccComputeRouterNat_withManualIpAndSubnetConfiguration|TestAccComputeRouterNat_withNatIpsAndDrainNatIps|TestAccComputeRouter_noRegion|TestAccComputeRouterNat_withDisabledIndependentEndpointMapping|TestAccComputeRouter_basic|TestAccComputeRouter_full|TestAccComputeRouter_update|TestAccComputeRouter_updateAddRemoveBGP|TestAccComputeSecurityPolicy_basic|TestAccComputeSecurityPolicy_withRuleExpr|TestAccComputeSnapshot_snapshotBasicExample|TestAccComputeSecurityPolicy_withRule|TestAccComputeSecurityPolicy_withAdaptiveProtection|TestAccComputeSecurityPolicy_update|TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccComputeSnapshot_encryption|TestAccComputeServiceAttachment_serviceAttachmentExplicitProjectsExample|TestAccComputeSslPolicy_update|TestAccComputeSslPolicy_update_to_custom|TestAccComputeSslPolicy_sslPolicyBasicExample|TestAccComputeSubnetwork_subnetworkBasicExample|TestAccComputeSubnetwork_subnetworkLoggingConfigExample|TestAccComputeSubnetwork_subnetworkInternalL7lbExample|TestAccComputeSslPolicy_update_from_custom|TestAccComputeSubnetwork_basic|TestAccComputeSubnetwork_update|TestAccComputeSubnetworkIamPolicy|TestAccComputeSubnetwork_secondaryIpRanges|TestAccComputeSubnetwork_flowLogs|TestAccComputeTargetGrpcProxy_targetGrpcProxyBasicExample|TestAccComputeSubnetwork_flowLogsMigrate|TestAccComputeTargetInstance_targetInstanceBasicExample|TestAccComputeTargetInstance_targetInstanceCustomNetworkExample|TestAccComputeTargetHttpProxy_update|TestAccComputeTargetGrpcProxy_update|TestAccComputeTargetHttpProxy_targetHttpProxyHttpsRedirectExample|TestAccComputeTargetHttpsProxy_targetHttpsProxyBasicExample|TestAccComputeTargetHttpProxy_targetHttpProxyBasicExample|TestAccComputeTargetPool_basic|TestAccComputeTargetHttpsProxy_update|TestAccComputeSharedVpc_basic|TestAccComputeTargetSslProxy_update|TestAccComputeTargetSslProxy_targetSslProxyBasicExample|TestAccComputeTargetTcpProxy_targetTcpProxyBasicExample|TestAccComputeTargetPool_update|TestAccComputeTargetTcpProxy_update|TestAccComputeUrlMap_urlMapTrafficDirectorRouteExample|TestAccComputeUrlMap_urlMapTrafficDirectorPathExample|TestAccComputeUrlMap_urlMapTrafficDirectorRoutePartialExample|TestAccComputeUrlMap_urlMapTrafficDirectorPathPartialExample|TestAccComputeUrlMap_urlMapHeaderBasedRoutingExample|TestAccComputeUrlMap_urlMapBasicExample|TestAccComputeUrlMap_urlMapParameterBasedRoutingExample|TestAccComputeUrlMap_defaultRouteActionUrlRewrite|TestAccComputeUrlMap_advanced|TestAccComputeUrlMap_update_path_matcher|TestAccComputeUrlMap_defaultRouteActionPathUrlRewrite|TestAccComputeUrlMap_defaultRouteActionTrafficDirectorPathUpdate|TestAccComputeUrlMap_noPathRulesWithUpdate|TestAccComputeUrlMap_trafficDirectorUpdate|TestAccComputeUrlMap_trafficDirectorPathUpdate|TestAccComputeUrlMap_defaultUrlRedirect|TestAccComputeUrlMap_defaultRouteActionTrafficDirectorUpdate|TestAccComputeUrlMap_trafficDirectorRemoveRouteRule|TestAccComputeVpnGateway_targetVpnGatewayBasicExample|TestAccComputeVpnTunnel_vpnTunnelBasicExample|TestAccComputeVpnTunnel_vpnTunnelBetaExample|TestAccComputeVpnTunnel_regionFromGateway|TestAccComputeVpnTunnel_defaultTrafficSelectors|TestAccComputeVpnTunnel_router|TestAccContainerCluster_basic|TestAccContainerCluster_withAddons|TestAccContainerCluster_withNotificationConfig|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccContainerCluster_withILBSubsetting|TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_withReleaseChannelEnabled|TestAccContainerCluster_withReleaseChannelEnabledDefaultVersion|TestAccContainerCluster_regionalWithNodePool|TestAccContainerCluster_regional|TestAccContainerCluster_withMasterAuthorizedNetworksConfig|TestAccContainerCluster_withTelemetryEnabled|TestAccContainerCluster_withPrivateClusterConfig|TestAccContainerCluster_withTpu|TestAccContainerCluster_regionalWithNodeLocations|TestAccContainerCluster_withIntraNodeVisibility|TestAccContainerCluster_withVersion|TestAccContainerCluster_withNodeConfig|TestAccContainerCluster_withNodeConfigScopeAlias|TestAccContainerCluster_updateVersion|TestAccContainerCluster_withNodeConfigShieldedInstanceConfig|TestAccContainerCluster_network|TestAccContainerCluster_withWorkloadMetadataConfig|TestAccContainerCluster_withSandboxConfig|TestAccContainerCluster_backend|TestAccContainerCluster_withNodePoolBasic|TestAccContainerCluster_withNodePoolUpdateVersion|TestAccContainerCluster_withNodePoolResize|TestAccContainerCluster_withNodePoolAutoscaling|TestAccContainerCluster_withNodePoolMultiple|TestAccContainerCluster_withNodePoolNodeConfig|TestAccContainerCluster_withMaintenanceWindow|TestAccContainerCluster_withRecurringMaintenanceWindow|TestAccContainerCluster_withMaintenanceExclusionWindow|TestAccContainerCluster_withIPAllocationPolicy_specificIPRanges|TestAccContainerCluster_withIPAllocationPolicy_existingSecondaryRanges|TestAccContainerCluster_withIPAllocationPolicy_specificSizes|TestAccContainerCluster_nodeAutoprovisioningDefaults|TestAccContainerCluster_withShieldedNodes|TestAccContainerCluster_nodeAutoprovisioning|TestAccContainerCluster_withAutopilot|TestAccContainerCluster_withAutoscalingProfile|TestAccContainerCluster_withFlexiblePodCIDR|TestAccContainerCluster_nodeAutoprovisioningDefaultsMinCpuPlatform|TestAccContainerCluster_withDNSConfig|TestAccContainerCluster_errorCleanDanglingCluster|TestAccContainerCluster_withBinaryAuthorization|TestAccContainerCluster_withMasterAuthorizedNetworksDisabled|TestAccContainerCluster_withAdvancedDatapath|TestAccContainerCluster_withDatabaseEncryption|TestAccContainerCluster_withResourceUsageExportConfig|TestAccContainerCluster_withEnableKubernetesAlpha|TestAccContainerNodePool_nodeLocations|TestAccContainerNodePool_basic|TestAccContainerNodePool_basicWithClusterId|TestAccContainerNodePool_maxPodsPerNode|TestAccContainerNodePool_withNodeConfig|TestAccContainerNodePool_withWorkloadIdentityConfig|TestAccContainerNodePool_withSandboxConfig|TestAccContainerNodePool_withNetworkConfig|TestAccContainerNodePool_withKubeletConfig|TestAccContainerNodePool_withLinuxNodeConfig|TestAccContainerNodePool_withInvalidUpgradeSettings|TestAccContainerNodePool_withUpgradeSettings|TestAccContainerNodePool_withGPU|TestAccContainerNodePool_withManagement|TestAccContainerNodePool_withNodeConfigScopeAlias|TestAccContainerNodePool_resize|TestAccContainerNodePool_regionalAutoscaling|TestAccContainerNodePool_autoscaling|TestAccContainerNodePool_version|TestAccContainerNodePool_regionalClusters|TestAccContainerNodePool_EmptyGuestAccelerator|TestAccContainerNodePool_012_ConfigModeAttr|TestAccContainerNodePool_shieldedInstanceConfig|TestAccContainerNodePool_ephemeralStorageConfig|TestAccDataCatalogPolicyTag_dataCatalogTaxonomiesPolicyTagBasicExample|TestAccDataCatalogPolicyTag_dataCatalogTaxonomiesPolicyTagChildPoliciesExample|TestAccDataCatalogTaxonomy_dataCatalogTaxonomyBasicExample|TestAccDataFusionInstance_dataFusionInstanceBasicExample|TestAccDataFusionInstance_dataFusionInstanceFullExample|TestAccDataprocCluster_withInternalIpOnlyTrueAndShieldedConfig|TestAccDataprocWorkflowTemplate_basic|TestAccDataprocMetastoreService_dataprocMetastoreServiceBasicExample|TestAccDNSManagedZone_dnsManagedZonePrivateExample|TestAccDNSManagedZone_dnsManagedZonePrivatePeeringExample|TestAccDNSManagedZone_dnsManagedZoneServiceDirectoryExample|TestAccDNSManagedZone_privateForwardingUpdate|TestAccDNSManagedZone_privateUpdate|TestAccDNSManagedZone_reverseLookup|TestAccDNSPolicy_update|TestAccDNSPolicy_dnsPolicyBasicExample|TestAccEssentialContactsContact_essentialContactExample|TestAccFilestoreInstance_filestoreInstanceBasicExample|TestAccFilestoreInstance_filestoreInstanceFullExample|TestAccFilestoreInstance_update|TestAccGKEHubMembership_gkehubMembershipBasicExample|TestAccGKEHubMembership_gkehubMembershipIssuerExample|TestAccSecurityScannerScanConfig_scanConfigUpdate|TestAccProject_deleteDefaultNetwork|TestAccHealthcareDicomStore_healthcareDicomStoreBqStreamExample|TestAccHealthcareHl7V2Store_healthcareHl7V2StoreParserConfigExample|TestAccHealthcareHl7V2Store_healthcareHl7V2StoreUnschematizedExample|TestAccIAMBetaWorkloadIdentityPool_iamWorkloadIdentityPoolBasicExample|TestAccIAMBetaWorkloadIdentityPool_iamWorkloadIdentityPoolFullExample|TestAccIAMBetaWorkloadIdentityPoolProvider_iamWorkloadIdentityPoolProviderAwsBasicExample|TestAccIAMBetaWorkloadIdentityPoolProvider_iamWorkloadIdentityPoolProviderAwsFullExample|TestAccHealthcareHl7V2Store_basic|TestAccIAMBetaWorkloadIdentityPoolProvider_iamWorkloadIdentityPoolProviderOidcBasicExample|TestAccIAMBetaWorkloadIdentityPoolProvider_iamWorkloadIdentityPoolProviderOidcFullExample|TestAccNetworkManagementConnectivityTest_networkManagementConnectivityTestInstancesExample|TestAccNetworkManagementConnectivityTest_update|TestAccNetworkManagementConnectivityTest_networkManagementConnectivityTestAddressesExample|TestAccNotebooksInstance_notebookInstanceFullExample|TestAccOSConfigGuestPolicies_osConfigGuestPoliciesBasicExample|TestAccOSConfigPatchDeployment_osConfigPatchDeploymentInstanceExample|TestAccPrivatecaCaPool_privatecaCapoolUpdate|TestAccPrivatecaCaPool_privatecaCapoolAllFieldsExample|TestAccPrivatecaCaPool_privatecaCapoolEmptyBaseline|TestAccPrivatecaCertificate_privatecaCertificateConfigExample|TestAccPrivatecaCertificate_privatecaCertificateCsrExample|TestAccPrivatecaCertificate_privatecaCertificateNoAuthorityExample|TestAccPubsubSchema_pubsubSchemaBasicExample|TestAccRedisInstance_redisInstanceFullExample|TestAccSecurityScannerScanConfig_scanConfigBasicExample|TestAccServiceNetworkingConnection_create|TestAccServiceNetworkingConnection_update|TestAccServiceDirectoryEndpoint_serviceDirectoryEndpointBasicExample|TestAccServiceDirectoryNamespace_serviceDirectoryNamespaceBasicExample|TestAccServiceDirectoryService_serviceDirectoryServiceBasicExample|TestAccServiceUsageConsumerQuotaOverride_consumerQuotaOverrideExample|TestAccServiceUsageConsumerQuotaOverride_regionConsumerQuotaOverrideExample|TestAccServiceUsageConsumerQuotaOverride_consumerQuotaOverrideZeroValueExample|TestAccSqlDatabaseInstance_basicMSSQL|TestAccSqlDatabaseInstance_settings_checkServiceNetworking|TestAccSqlDatabaseInstance_withPrivateNetwork|TestAccSqlDatabaseInstance_multipleOperations|TestAccTPUNode_tpuNodeFullExample|TestAccVPCAccessConnector_vpcAccessConnectorSharedVPCExample|TestAccVPCAccessConnector_vpcAccessConnectorThroughput|TestAccComputeResourceUsageExportBucket You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=204923 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
…udPlatform#4945) * Add support for dns_config to google_container_cluster * Update mmv1/third_party/terraform/website/docs/r/container_cluster.html.markdown beta description Co-authored-by: Sam Levenick <[email protected]> Co-authored-by: Sam Levenick <[email protected]>
Add support for dns_config to google_container_cluster
fix hashicorp/terraform-provider-google#9494
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)