Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc code changes #4944

Merged
merged 1 commit into from
Jul 2, 2021
Merged

Misc code changes #4944

merged 1 commit into from
Jul 2, 2021

Conversation

Akasurde
Copy link
Contributor

@Akasurde Akasurde commented Jul 2, 2021

  • Unnecessary "else" after "return"
  • Handle if service account file is missing with proper user message

Signed-off-by: Abhijeet Kasurde [email protected]

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

ansible: misc fixes for module_utils/gcp_utils.py

* Unnecessary "else" after "return"
* Handle if service account file is missing with proper user message

Signed-off-by: Abhijeet Kasurde <[email protected]>
@google-cla google-cla bot added the cla: yes label Jul 2, 2021
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@melinath, please review this PR or find an appropriate assignee.

@modular-magician modular-magician requested a review from melinath July 2, 2021 06:42
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
Ansible: Diff ( 1 file changed, 30 insertions(+), 38 deletions(-))

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@melinath melinath merged commit 7c0038d into GoogleCloudPlatform:master Jul 2, 2021
@Akasurde Akasurde deleted the misc branch July 2, 2021 15:42
@Akasurde
Copy link
Contributor Author

Akasurde commented Jul 2, 2021

@melinath Thanks for the review and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants