Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Azure Blob Storage Transfer #4751

Merged

Conversation

upodroid
Copy link
Contributor

Fixes: hashicorp/terraform-provider-google#8695

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

storage-transfer: added support for `azure_blob_storage_data_source` to `google_storage_transfer_job`

upodroid added 17 commits August 3, 2020 12:29
Co-authored-by: upodroid <[email protected]>
Co-authored-by: upodroid <[email protected]>
@google-cla google-cla bot added the cla: yes label Apr 29, 2021
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@melinath, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 118 insertions(+), 8 deletions(-))
Terraform Beta: Diff ( 5 files changed, 120 insertions(+), 11 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=184950"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 120 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 3 files changed, 120 insertions(+), 10 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=184950"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeBackendService_internalLoadBalancing|TestAccComputeInstance_serviceAccount_updated0to1to0scopes You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=185043"

1 similar comment
@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeBackendService_internalLoadBalancing|TestAccComputeInstance_serviceAccount_updated0to1to0scopes You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=185043"

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable - just a couple requests / questions. Thanks for the PR!

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 121 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 4 files changed, 122 insertions(+), 11 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=185117"

@melinath
Copy link
Member

melinath commented Jun 3, 2021

/gcbrun; the last failure was a transient agent issue. @upodroid could you make the last requested change? Then I can approve and merge.

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=190388"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 121 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 3 files changed, 121 insertions(+), 10 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=190391"

@modular-magician

This comment has been minimized.

@modular-magician

This comment has been minimized.

@modular-magician

This comment has been minimized.

@melinath melinath self-requested a review June 3, 2021 17:05
@melinath
Copy link
Member

melinath commented Jun 4, 2021

/gcbrun

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=190576"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 120 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 2 files changed, 120 insertions(+), 9 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=190577"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataprocClusterIamBinding|TestAccDataprocClusterIamMember|TestAccDataprocClusterIamPolicy|TestAccDataprocCluster_updatable|TestAccDataprocCluster_withStagingBucket|TestAccDataprocCluster_withConfigOverrides|TestAccDataprocCluster_withTempBucket|TestAccDataprocCluster_withInitAction|TestAccDataprocJobIamBinding|TestAccDataprocJobIamMember|TestAccDataprocCluster_withServiceAcc|TestAccDataprocJob_updatable|TestAccDataprocJobIamPolicy|TestAccDataprocJob_PySpark|TestAccDataprocJob_Hive|TestAccDataprocJob_Spark|TestAccDataprocJob_Hadoop|TestAccDataprocJob_Pig|TestAccDataprocJob_SparkSql You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=190583"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Azure blob storage transfers
3 participants