Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow referencing IPs by reference in google_compute_forwarding_rule #4673

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

rileykarson
Copy link
Member

@rileykarson rileykarson commented Apr 7, 2021

Part of hashicorp/terraform-provider-google#8454

This API only accepts a reference under some circumstances, but returns the raw IP. This adopts the strategy used in google_compute_global_forwarding_rule in hashicorp/terraform-provider-google#8018 to resolve that issue. Thinking about it, I don't love the solution- if a user changes the address they're referencing, Terraform won't see a diff- but it's consistent and means if we fix that issue with GFR we can apply the same fix to FR.

I removed the custom Terraform documentation for each field (adding a note on top of the MMv1 docs) and updated the MMv1 docs at the same time, mostly removing the rules about what IP can be used where & linking the canonical source instead.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added the ability to specify `google_compute_forwarding_rule.ip_address` by a reference in addition to raw IP address

@google-cla google-cla bot added the cla: yes label Apr 7, 2021
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 78 insertions(+), 97 deletions(-))
Terraform Beta: Diff ( 5 files changed, 78 insertions(+), 97 deletions(-))
Inspec: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=181255"

@rileykarson
Copy link
Member Author

@rileykarson rileykarson requested review from a team and melinath and removed request for a team April 7, 2021 20:59
Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - seems like a reasonable standardization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants