Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for description to tag template fields #4650

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

melinath
Copy link
Member

@melinath melinath commented Apr 1, 2021

Upstreams hashicorp/terraform-provider-google#8811. Resolves hashicorp/terraform-provider-google#8810.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

datacatalog: added `description` field to `google_data_catalog_tag_template ` resource

@google-cla
Copy link

google-cla bot commented Apr 1, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Apr 1, 2021
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 25 insertions(+))
Terraform Beta: Diff ( 4 files changed, 27 insertions(+), 3 deletions(-))
TF Conversion: Diff ( 1 file changed, 11 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=180196"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigGkeExample|TestAccContainerCluster_withILBSubsetting|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccContainerCluster_regionalWithNodePool|TestAccContainerCluster_withTpu|TestAccContainerCluster_withPrivateClusterConfig|TestAccContainerCluster_withIntraNodeVisibility|TestAccContainerNodePool_nodeLocations|TestAccContainerNodePool_maxPodsPerNode|TestAccContainerNodePool_withGPU|TestAccContainerNodePool_regionalAutoscaling|TestAccContainerNodePool_resize|TestAccContainerNodePool_012_ConfigModeAttr|TestAccContainerNodePool_EmptyGuestAccelerator|TestAccDataprocClusterIamBinding|TestAccDataprocClusterIamMember|TestAccDataprocClusterIamPolicy|TestAccDataprocCluster_updatable|TestAccDataprocCluster_withTempBucket|TestAccDataprocCluster_withStagingBucket|TestAccDataprocCluster_withInitAction|TestAccDataprocCluster_withConfigOverrides|TestAccDataprocCluster_withServiceAcc|TestAccDataprocJobIamBinding|TestAccDataprocJobIamMember|TestAccDataprocJobIamPolicy|TestAccDataprocJob_updatable|TestAccDataprocJob_Spark|TestAccDataprocJob_Hadoop|TestAccDataprocJob_PySpark|TestAccDataprocJob_Hive|TestAccDataprocJob_Pig|TestAccDataprocJob_SparkSql|TestAccStorageHmacKey_update You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=180303"

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode: TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock|TestAccDataprocCluster_withConfigOverrides|TestAccDataprocCluster_withStagingBucket|TestAccDataprocCluster_updatable|TestAccDataprocCluster_withTempBucket Please fix these to complete your PR

@melinath melinath requested review from a team and ScottSuarez and removed request for a team April 2, 2021 15:37
@geirsagberg
Copy link
Contributor

@googlebot I fixed it.

@google-cla
Copy link

google-cla bot commented Apr 3, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@geirsagberg
Copy link
Contributor

@googlebot I consent.

@google-cla google-cla bot added cla: yes and removed cla: no labels Apr 4, 2021
@geirsagberg
Copy link
Contributor

@melinath @ScottSuarez Anything I can do to make the generate-diffs check succeed? Not quite sure what it means...

@melinath
Copy link
Member Author

melinath commented Apr 6, 2021

@geirsagberg the generage-diffs failure represents test failures, but they seem to be unrelated to this PR, so they don't block it being merged. Thanks for checking in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_data_catalog_tag_template missing description for fields
4 participants