Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed reference to 'v3' providers #4524

Merged
merged 1 commit into from
Mar 2, 2021

Conversation

melinath
Copy link
Member

@melinath melinath commented Feb 23, 2021

These lines were already being removed by the goimports run during provider generation.

See hashicorp/terraform-provider-google#8538 for details. This change may not be strictly necessary but it'll be a confusing reference otherwise.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


@google-cla google-cla bot added the cla: yes label Feb 23, 2021
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=174032"

@melinath melinath requested a review from ScottSuarez February 23, 2021 23:36
These lines were already being removed by the goimports run during provider generation.
@melinath melinath force-pushed the remove-v3-reference branch from ac40b8e to 9c14b18 Compare February 23, 2021 23:50
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 259 insertions(+), 11 deletions(-))
Terraform Beta: Diff ( 3 files changed, 259 insertions(+), 11 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=174038"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccRedisInstance_redisInstancePrivateServiceExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=174126"

@melinath
Copy link
Member Author

It looks like the tests are failing because the provider repos still bill themselves as /v3, so switching off /v3 here looks like it's adding a new dependency (and that causes some compile issues). Once the PRs for tpg and tpgb are merged, this should work as expected.

@melinath melinath merged commit b026f9a into GoogleCloudPlatform:master Mar 2, 2021
@melinath melinath deleted the remove-v3-reference branch March 2, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants