-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address bigquery's low-but-fast-refreshing quota by accepting and retrying quota errors. #4094
Address bigquery's low-but-fast-refreshing quota by accepting and retrying quota errors. #4094
Conversation
…rying quota errors.
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 2 files changed, 15 insertions(+), 4 deletions(-)) |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=151767" |
// concurrent operations (which are implemented in terms of 'edit quota'). | ||
func isBigqueryIAMQuotaError(err error) (bool, string) { | ||
if gerr, ok := err.(*googleapi.Error); ok { | ||
if gerr.Code == 403 && strings.Contains(strings.ToLower(gerr.Body), "Exceeded rate limits") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will never return true because the lowercase error body will never have an E in it.
Also, this error message seems different than the one in the GH issue- intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, missed that! The full error is
Error: Error creating DatasetAccess: googleapi: Error 403: Exceeded rate limits: too many dataset metadata update operations for this dataset. For more information, see https://cloud.google.com/bigquery/troubleshooting-errors, rateLimitExceeded
I'll lowercase the string there.
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 2 files changed, 15 insertions(+), 4 deletions(-)) |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=151771" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceGoogleSQLCaCerts_basic|TestAccDataSourceSqlDatabaseInstance_basic|TestAccProviderMeta_setModuleName|TestAccCloudRunService_cloudRunServiceSqlExample|TestAccSQLDatabase_sqlDatabaseBasicExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=151777" |
Fixes hashicorp/terraform-provider-google#7224
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)